Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Dev to Test #1182

Merged
merged 13 commits into from
Dec 12, 2023
Merged

Release Dev to Test #1182

merged 13 commits into from
Dec 12, 2023

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

n/a

Description of Changes

Release latest changes from Dev to Test

Testing Notes

Deploys/works as expected.

curtisupshall and others added 12 commits November 10, 2023 09:36
* SIMSBIOHUB-117
* SIMSBIOHUB-226
* SIMSBIOHUB-258
* SIMSBIOHUB-296
* SIMSBIOHUB-297
* SIMSBIOHUB-313
* SIMSBIOHUB-323
* SIMSBIOHUB-324
* SIMSBIOHUB-325
* SIMSBIOHUB-331
* SIMSBIOHUB-334
* SIMSBIOHUB-335
* SIMSBIOHUB-336
* SIMSBIOHUB-337
* SIMSBIOHUB-341
* SIMSBIOHUB-342
* SIMSBIOHUB-343
* SIMSBIOHUB-344
* SIMSBIOHUB-345
* SIMSBIOHUB-347
* SIMSBIOHUB-348
* SIMSBIOHUB-350
* SIMSBIOHUB-352
* SIMSBIOHUB-353
* SIMSBIOHUB-354
* SIMSBIOHUB-355
* SIMSBIOHUB-356
* SIMSBIOHUB-363
* SIMSBIOHUB-371
* SIMSBIOHUB-361
SIMSBIOHUB-345-Fix: Updated date time displays , fixed misc UI issues, added a snackbar for sample site deletion errors
Manage Animals full screen layout + card displays with dialog forms.
Telemetry / Device form updates + validation improvements.
…crumbs (#1170)

* sticky headers+breadcrumb added

* convert into Survey header into generic structure for header across pages
Solves out of memory heap issue with builds.
Problematic sections: LoadingButtonProps, ButtonProps, SxProps and sx prop applied to LoadingButton.
Comands for running ts-trace and analyze
* Fixing UI Issues

* Minor fix for Sampling Site List Spacing

* Fixing minor issues with theme and observation header
* Adds a validation state object to the observationTableContext
* Adds error styling to Observations Table controls that have failed validation
* Adds an alert to the Observations Table, allowing users to page through validation errors
* Prevents saving to the Observations Table unless all column values are valid
* Fixed skeleton loaders
* General UI fixes
As a Project Coordinator, I want to publish my Survey to BioHub.
Package data in SIMS into a well-formatted generic JSON structure to send over to BioHub.
* Adjust API memory settings, set node env properly, adjust log levels
* Simplify zod geojson schema
* Remove zod from keycloak token type definitions (hotspot).
Disable zod database response parsing in production.
Add query and zod timers in development.
* BugFix: Allow surveys to be created with $0 amounts.
BugFix: Fix api_set_context function
Fix api_set_context migration.
Fix non-unique key code smell.
@NickPhura NickPhura requested review from curtisupshall, KjartanE, MacQSL and al-rosenthal and removed request for curtisupshall December 11, 2023 21:49
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 1141 lines in your changes are missing coverage. Please review.

Comparison is base (0e8754f) 63.16% compared to head (8c66d58) 58.15%.
Report is 32 commits behind head on test.

Files Patch % Lines
app/src/contexts/observationsTableContext.tsx 0.00% 193 Missing ⚠️
app/src/contexts/telemetryTableContext.tsx 0.00% 189 Missing ⚠️
api/src/utils/xlsx-utils/worksheet-utils.ts 17.34% 81 Missing ⚠️
...c/components/data-grid/DataGridValidationAlert.tsx 0.00% 56 Missing ⚠️
...src/components/publish/DwcaPublishSurveyDialog.tsx 0.00% 42 Missing ⚠️
app/src/components/map/components/DrawControls.tsx 2.63% 37 Missing ⚠️
.../{projectId}/survey/{surveyId}/telemetry/upload.ts 0.00% 32 Missing ⚠️
app/src/contexts/taxonomyContext.tsx 0.00% 32 Missing ⚠️
api/src/utils/xlsx-utils/cell-utils.ts 22.85% 27 Missing ⚠️
api/src/repositories/observation-repository.ts 46.51% 20 Missing and 3 partials ⚠️
... and 71 more
Additional details and impacted files
@@            Coverage Diff             @@
##             test    #1182      +/-   ##
==========================================
- Coverage   63.16%   58.15%   -5.02%     
==========================================
  Files         536      590      +54     
  Lines       16367    17943    +1576     
  Branches     2516     2763     +247     
==========================================
+ Hits        10339    10435      +96     
- Misses       5334     6824    +1490     
+ Partials      694      684      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SIMSBIOHUB-333: Telemetry Table and required API endpoints added to view and manage telemetry data for deployments

---------

Co-authored-by: Alfred Rosenthal <[email protected]>
Co-authored-by: Mac Deluca <[email protected]>
Co-authored-by: Kjartan <[email protected]>
Copy link

sonarcloud bot commented Dec 12, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

6.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪

@NickPhura NickPhura merged commit 92582a1 into test Dec 12, 2023
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants