Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Fix api_set_context migration. #1181

Merged
merged 1 commit into from
Dec 11, 2023
Merged

BugFix: Fix api_set_context migration. #1181

merged 1 commit into from
Dec 11, 2023

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

n/a

Description of Changes

Fix api_set_context migration.
Fix non-unique key code smell.

Testing Notes

  • DB Setup deploys successfully.
  • App works as normal.

Fix non-unique key code smell.
Copy link

sonarcloud bot commented Dec 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0d2cf68) 60.09% compared to head (433f19a) 60.09%.

Files Patch % Lines
...features/surveys/components/SamplingMethodForm.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1181      +/-   ##
==========================================
- Coverage   60.09%   60.09%   -0.01%     
==========================================
  Files         569      569              
  Lines       17160    17161       +1     
  Branches     2658     2660       +2     
==========================================
  Hits        10313    10313              
- Misses       6167     6168       +1     
  Partials      680      680              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran this locally and it works

@NickPhura NickPhura merged commit ec188ab into dev Dec 11, 2023
19 of 21 checks passed
@NickPhura NickPhura deleted the npBugFixes-3 branch December 11, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants