Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-331: Keycloak Library Updates #1150

Closed
wants to merge 19 commits into from
Closed

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-331

Description of Changes

Swap out old keycloak libraries for newer more up to date libraries.

Remove login and logout pages.

Refactor the keycloakWrapper, and update code/tests as necessary.

Testing Notes

Anything to do with logging in/out works as before.

curtisupshall and others added 19 commits October 18, 2023 12:54
* Various survey page layout changes
* Adds the ability to see added survey observations in a map view
* Minor Fixes / UI Tweaks
* Fix permit component list key
* Rename old sampling method form to sampling strategy

Co-authored-by: Nick Phura <[email protected]>
* Add's UIs for uploading CSV files to survey observations
* Adds a new database table to track survey observation CSV submissions, survey_observation_submission
* Alters the survey_observation table to make optional the sampling site, method, and period columns
* Adds service and repo methods for processing observation CSVs
* Survey Study area can now import files with multiple features
* Drawn features can be created and saved to a survey
* New card for displaying and editing map features
* Region selector updated
* Adds Sampling Site record count to title area, Example: Sampling Sites (10)
* Adds Observation record count to title area of observations map component and manage observations page, Example: Observations (10)
* Adds 'supplementaryObservationData' section to get survey observations endpoint. This allows observation record counts to be displayed, even if the get observations response becomes paginated or virtualized at a later date
)

* Fixed an issue where the yup schema used for editing sampling methods used the wrong field for a date overlap check.
* Removed an unintended required().
* Added a refresh call when submitting sampling method changes so they are reflected in the UI. Otherwise you will still see the previous value if you go back to the sampling methods view even though the new value did save to the db.
* Added snackbar popup upon successfully saving observations.
* Removed single-click to edit; Fixed bug that made row go into edit mode when clicking row delete icon.
* Added seconds to the observation time
Refactor the keycloakWrapper, and update code/tests as needed.
@NickPhura
Copy link
Collaborator Author

Opened against wrong base branch!

@NickPhura NickPhura closed this Oct 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
7.6% 7.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants