Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funding Source Testing #1073

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Funding Source Testing #1073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3984e99
adding tests for funding sources
al-rosenthal Aug 22, 2023
31650e5
Merge branch 'dev' into fundingtesting
NickPhura Aug 22, 2023
793a791
renamed file
al-rosenthal Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 160 additions & 0 deletions app/src/features/funding-sources/components/CreateFundingSource.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
import { AuthStateContext } from 'contexts/authStateContext';
import { DialogContextProvider } from 'contexts/dialogContext';
import { createMemoryHistory } from 'history';
import { useBiohubApi } from 'hooks/useBioHubApi';
import { IGetFundingSourceResponse, IGetFundingSourcesResponse } from 'interfaces/useFundingSourceApi.interface';
import { Router } from 'react-router';
import { getMockAuthState, SystemAdminAuthState } from 'test-helpers/auth-helpers';
import { act, cleanup, fireEvent, render, waitFor } from 'test-helpers/test-utils';
import CreateFundingSource from './CreateFundingSource';

jest.mock('../../../hooks/useBioHubApi');
const mockBioHubApi = useBiohubApi as jest.Mock;
const mockUseApi = {
funding: {
getFundingSources: jest.fn<Promise<IGetFundingSourcesResponse[]>, []>(),
postFundingSource: jest.fn<Promise<IGetFundingSourceResponse[]>, []>()
}
};
const history = createMemoryHistory();
describe('CreateFundingSource', () => {
beforeEach(() => {
mockBioHubApi.mockImplementation(() => mockUseApi);
mockUseApi.funding.getFundingSources.mockClear();
mockUseApi.funding.postFundingSource.mockClear();
});

afterEach(() => {
cleanup();
});

it('renders with empty form fields', async () => {
const authState = getMockAuthState({ base: SystemAdminAuthState });

mockUseApi.funding.getFundingSources.mockResolvedValue([]);

const onClose = jest.fn();

const { getByTestId } = render(
<Router history={history}>
<AuthStateContext.Provider value={authState}>
<DialogContextProvider>
<CreateFundingSource onClose={onClose} open={true} />
</DialogContextProvider>
</AuthStateContext.Provider>
</Router>
);

await waitFor(() => {
expect(getByTestId('name')).toBeVisible();
expect(getByTestId('description')).toBeVisible();
expect(getByTestId('start_date')).toBeVisible();
expect(getByTestId('end_date')).toBeVisible();
});
});

it('renders form errors when submitting with no data', async () => {
const authState = getMockAuthState({ base: SystemAdminAuthState });
mockUseApi.funding.getFundingSources.mockResolvedValue([]);
const onClose = jest.fn();

const { findByTestId, getByText } = render(
<Router history={history}>
<AuthStateContext.Provider value={authState}>
<DialogContextProvider>
<CreateFundingSource onClose={onClose} open={true} />
</DialogContextProvider>
</AuthStateContext.Provider>
</Router>
);

await act(async () => {
// submit empty form
const saveChangesButton = await findByTestId('edit-dialog-save');
fireEvent.click(saveChangesButton);
});

await waitFor(() => {
expect(getByText('Name is Required', { exact: false })).toBeVisible();
expect(getByText('Description is Required', { exact: false })).toBeVisible();
});
});

it('renders name used error when submitting with a previously used name', async () => {
const authState = getMockAuthState({ base: SystemAdminAuthState });
mockUseApi.funding.getFundingSources.mockResolvedValue([
{
funding_source_id: 1,
name: 'Used Name',
description: '',
start_date: '',
end_date: '',
revision_count: 1,
survey_reference_count: 0,
survey_reference_amount_total: 0
}
]);
const onClose = jest.fn();

const { findByTestId, getByText, getByTestId } = render(
<Router history={history}>
<AuthStateContext.Provider value={authState}>
<DialogContextProvider>
<CreateFundingSource onClose={onClose} open={true} />
</DialogContextProvider>
</AuthStateContext.Provider>
</Router>
);

await act(async () => {
// Fill form
const nameInput = getByTestId('name');
fireEvent.change(nameInput, { target: { value: 'Used Name' } });

const descriptionInput = getByTestId('description');
fireEvent.change(descriptionInput, { target: { value: 'description' } });

// submit form
const saveChangesButton = await findByTestId('edit-dialog-save');
fireEvent.click(saveChangesButton);
});

await waitFor(() => {
expect(getByText('Name has already been used', { exact: false })).toBeVisible();
});
});

it('form submits properly', async () => {
const authState = getMockAuthState({ base: SystemAdminAuthState });
mockUseApi.funding.getFundingSources.mockResolvedValue([]);
const onClose = jest.fn();

const { findByTestId, getByTestId } = render(
<Router history={history}>
<AuthStateContext.Provider value={authState}>
<DialogContextProvider>
<CreateFundingSource onClose={onClose} open={true} />
</DialogContextProvider>
</AuthStateContext.Provider>
</Router>
);

await act(async () => {
// Fill form
const nameInput = getByTestId('name');
fireEvent.change(nameInput, { target: { value: 'Used Name' } });

const descriptionInput = getByTestId('description');
fireEvent.change(descriptionInput, { target: { value: 'description' } });

// submit form
const saveChangesButton = await findByTestId('edit-dialog-save');
fireEvent.click(saveChangesButton);
});

await waitFor(() => {
expect(mockUseApi.funding.postFundingSource).toHaveBeenCalledTimes(1);
expect(onClose).toHaveBeenCalledTimes(1);
});
});
});
109 changes: 109 additions & 0 deletions app/src/features/funding-sources/components/DeleteFundingSource.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
import { cleanup, waitFor } from '@testing-library/react';
import { AuthStateContext } from 'contexts/authStateContext';
import { DialogContextProvider } from 'contexts/dialogContext';
import { createMemoryHistory } from 'history';
import { useBiohubApi } from 'hooks/useBioHubApi';
import { IGetFundingSourceResponse } from 'interfaces/useFundingSourceApi.interface';
import { Router } from 'react-router';
import { getMockAuthState, SystemAdminAuthState } from 'test-helpers/auth-helpers';
import { render } from 'test-helpers/test-utils';
import DeleteFundingSource from './DeleteFundingSource';

jest.mock('../../../hooks/useBioHubApi');
const mockBioHubApi = useBiohubApi as jest.Mock;
const mockUseApi = {
funding: {
getFundingSource: jest.fn<Promise<IGetFundingSourceResponse>, []>()
}
};
const history = createMemoryHistory();

describe('DeleteFundingSource', () => {
beforeEach(() => {
mockBioHubApi.mockImplementation(() => mockUseApi);
mockUseApi.funding.getFundingSource.mockClear();
});
afterEach(() => {
cleanup();
});

it('renders delete option', async () => {
const authState = getMockAuthState({ base: SystemAdminAuthState });
mockUseApi.funding.getFundingSource.mockResolvedValue({
funding_source: {
funding_source_id: 1,
name: 'Funding Source Name',
description: 'funding source description',
start_date: null,
end_date: null,
revision_count: 1,
survey_reference_count: 0,
survey_reference_amount_total: 0
},
funding_source_survey_references: []
});

const onClose = jest.fn();
const openViewModal = jest.fn();

const { findByText } = render(
<Router history={history}>
<AuthStateContext.Provider value={authState}>
<DialogContextProvider>
<DeleteFundingSource fundingSourceId={1} open={true} onClose={onClose} openViewModal={openViewModal} />
</DialogContextProvider>
</AuthStateContext.Provider>
</Router>
);

await waitFor(async () => {
expect(mockUseApi.funding.getFundingSource).toBeCalled();
expect(await findByText('Delete Funding Source?')).toBeVisible();
});
});

it('renders view more dialog', async () => {
const authState = getMockAuthState({ base: SystemAdminAuthState });
mockUseApi.funding.getFundingSource.mockResolvedValue({
funding_source: {
funding_source_id: 1,
name: 'Funding Source Name',
description: 'funding source description',
start_date: null,
end_date: null,
revision_count: 1,
survey_reference_count: 0,
survey_reference_amount_total: 0
},
funding_source_survey_references: [
{
survey_funding_source_id: 1,
survey_id: 1,
funding_source_id: 1,
amount: 1,
revision_count: 1,
project_id: 1,
survey_name: 'Survey'
}
]
});

const onClose = jest.fn();
const openViewModal = jest.fn();

const { findByText } = render(
<Router history={history}>
<AuthStateContext.Provider value={authState}>
<DialogContextProvider>
<DeleteFundingSource fundingSourceId={1} open={true} onClose={onClose} openViewModal={openViewModal} />
</DialogContextProvider>
</AuthStateContext.Provider>
</Router>
);

await waitFor(async () => {
expect(mockUseApi.funding.getFundingSource).toBeCalled();
expect(await findByText("You can't delete this funding source")).toBeVisible();
});
});
});
108 changes: 108 additions & 0 deletions app/src/features/funding-sources/components/EditFundingSource.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
import { AuthStateContext } from 'contexts/authStateContext';
import { DialogContextProvider } from 'contexts/dialogContext';
import { createMemoryHistory } from 'history';
import { useBiohubApi } from 'hooks/useBioHubApi';
import { IGetFundingSourceResponse, IGetFundingSourcesResponse } from 'interfaces/useFundingSourceApi.interface';
import { Router } from 'react-router';
import { getMockAuthState, SystemAdminAuthState } from 'test-helpers/auth-helpers';
import { act, cleanup, fireEvent, render, waitFor } from 'test-helpers/test-utils';
import EditFundingSource from './EditFundingSource';

jest.mock('../../../hooks/useBioHubApi');
const mockBioHubApi = useBiohubApi as jest.Mock;
const mockUseApi = {
funding: {
getFundingSources: jest.fn<Promise<IGetFundingSourcesResponse[]>, []>(),
getFundingSource: jest.fn<Promise<IGetFundingSourceResponse>, []>(),
putFundingSource: jest.fn<Promise<{ funding_source_id: number }>, []>()
}
};
const history = createMemoryHistory();
describe('EditFundingSource', () => {
beforeEach(() => {
mockBioHubApi.mockImplementation(() => mockUseApi);
mockUseApi.funding.getFundingSources.mockClear();
mockUseApi.funding.getFundingSource.mockClear();
mockUseApi.funding.putFundingSource.mockClear();
});

afterEach(() => {
cleanup();
});

it('renders with prefilled form fields', async () => {
const authState = getMockAuthState({ base: SystemAdminAuthState });

mockUseApi.funding.getFundingSources.mockResolvedValue([]);
mockUseApi.funding.getFundingSource.mockResolvedValue({
funding_source: {
funding_source_id: 1,
name: 'Funding Source Name',
description: 'funding source description',
start_date: null,
end_date: null,
revision_count: 1,
survey_reference_count: 0,
survey_reference_amount_total: 0
},
funding_source_survey_references: []
});

const onClose = jest.fn();

const { getByDisplayValue } = render(
<Router history={history}>
<AuthStateContext.Provider value={authState}>
<DialogContextProvider>
<EditFundingSource fundingSourceId={1} onClose={onClose} open={true} />
</DialogContextProvider>
</AuthStateContext.Provider>
</Router>
);
await waitFor(() => {
expect(getByDisplayValue('Funding Source Name', { exact: false })).toBeVisible();
expect(getByDisplayValue('funding source description', { exact: false })).toBeVisible();
});
});

it('form submits properly', async () => {
const authState = getMockAuthState({ base: SystemAdminAuthState });

mockUseApi.funding.getFundingSources.mockResolvedValue([]);
mockUseApi.funding.getFundingSource.mockResolvedValue({
funding_source: {
funding_source_id: 1,
name: 'Funding Source Name',
description: 'funding source description',
start_date: null,
end_date: null,
revision_count: 1,
survey_reference_count: 0,
survey_reference_amount_total: 0
},
funding_source_survey_references: []
});

const onClose = jest.fn();

const { findByTestId } = render(
<Router history={history}>
<AuthStateContext.Provider value={authState}>
<DialogContextProvider>
<EditFundingSource fundingSourceId={1} onClose={onClose} open={true} />
</DialogContextProvider>
</AuthStateContext.Provider>
</Router>
);

await act(async () => {
const button = await findByTestId('edit-dialog-save');
fireEvent.click(button);
});

await waitFor(() => {
expect(mockUseApi.funding.putFundingSource).toHaveBeenCalledTimes(1);
expect(onClose).toHaveBeenCalledTimes(1);
});
});
});
Loading