SIMSBIOHUB-154: System user table updates #1060

NickPhura · 2023-07-27T20:04:25Z

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-154?

Description of Changes

Add migration to:
- Add new system user permission tables
- Add new fields to system_user table
- Add new identity source type: UNVERIFIED
  - Used to classify a user with no IDIR/BCeID information (no verified credential)
Remove unused SYSTEM user identity source type (API/APP)
Update user seed
- Account for new system_user fields
Update database readme

Testing Notes

Migration runs successfully
Application functions as normal (new tables should not impact current functionality)

github-actions · 2023-07-27T20:04:38Z

Openshift URLs for the PR Deployment:

codecov · 2023-07-27T20:08:07Z

Codecov Report

Merging #1060 (42fe6ee) into dev (eb4d16d) will decrease coverage by 0.02%.
The diff coverage is 77.58%.

@@            Coverage Diff             @@
##              dev    #1060      +/-   ##
==========================================
- Coverage   67.57%   67.55%   -0.02%     
==========================================
  Files         403      403              
  Lines       12509    12570      +61     
  Branches     2088     2106      +18     
==========================================
+ Hits         8453     8492      +39     
- Misses       3522     3538      +16     
- Partials      534      540       +6

Files Changed	Coverage Δ
...c/paths/project/{projectId}/participants/create.ts	`86.11% <ø> (ø)`
api/src/paths/user/self.ts	`96.00% <ø> (ø)`
api/src/repositories/user-repository.ts	`97.91% <ø> (ø)`
app/src/features/admin/users/AccessRequestList.tsx	`75.55% <ø> (ø)`
app/src/features/admin/users/ActiveUsersList.tsx	`30.76% <ø> (ø)`
...pp/src/features/admin/users/AddSystemUsersForm.tsx	`15.38% <0.00%> (-4.62%)`	⬇️
...p/src/features/projects/list/ProjectsListTable.tsx	`62.96% <ø> (ø)`
...ojects/participants/AddProjectParticipantsForm.tsx	`0.00% <0.00%> (ø)`
app/src/hooks/useKeycloakWrapper.tsx	`70.17% <ø> (ø)`
app/src/pages/access/AccessRequestPage.tsx	`69.38% <ø> (ø)`
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* Remove unused `SYSTEM` user identity source type * Update user seed * Update database readme

github-actions · 2023-07-31T20:21:28Z

Openshift URLs for the PR Deployment:

database/src/migrations/20230727000000_system_user_enhancement.ts

al-rosenthal

👤

…ssion join table.

al-rosenthal

ran this locally and it worked after editing the user name ⚡

* Add keycloak user information zod schemas

Rename some keycloak interfaces

…to SIMSBIOHUB-154

al-rosenthal

I also noticed an issue under manage users tabs:

reviewing a request fails
adding a user fails

api/src/services/user-service.ts

api/src/repositories/user-repository.ts

KjartanE

🐈

api/src/paths/user/add.ts

api/src/services/keycloak-service.ts

api/src/utils/keycloak-utils.ts

curtisupshall

I added my alt BCeID Basic account (putting curtisupshalldev into the Username field), and the account was added as a System Administrator successfully. Then I logged into said account, but I was denied access. I then request access from my curtisupshalldev account, and approved it as a Data Administrator. So now there are two accounts with the same username - one that I explicitly added, and one that I approved.

app/src/features/admin/users/AddSystemUsersForm.tsx

curtisupshall

Code looks good; tested adding a user and it locally and works as expected 👑

al-rosenthal

🕶️

al-rosenthal

🧄

Fix code smell.

sonarcloud · 2023-08-09T19:02:47Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

al-rosenthal

🧯

NickPhura changed the title ~~SIMSBIOHUB-154: Add migration to enhance system user tables~~ SIMSBIOHUB-154: System user table updates Jul 27, 2023

NickPhura force-pushed the SIMSBIOHUB-154 branch from 245b04b to f16e6e7 Compare July 27, 2023 23:02

* Add migration to add system role permission tables.

509be55

* Remove unused `SYSTEM` user identity source type * Update user seed * Update database readme

NickPhura force-pushed the SIMSBIOHUB-154 branch from c087ab4 to 509be55 Compare July 31, 2023 20:17

NickPhura marked this pull request as ready for review July 31, 2023 20:21

ignore-skip

a6bcc2b

NickPhura requested review from curtisupshall, KjartanE and AlfredRosenthal July 31, 2023 20:21

al-rosenthal reviewed Jul 31, 2023

View reviewed changes

database/src/migrations/20230727000000_system_user_enhancement.ts Outdated Show resolved Hide resolved

database/src/migrations/20230727000000_system_user_enhancement.ts Outdated Show resolved Hide resolved

al-rosenthal previously approved these changes Jul 31, 2023

View reviewed changes

Update migration: fix minor issues, add inserts for system role permi…

439b8b2

…ssion join table.

NickPhura dismissed al-rosenthal’s stale review via 439b8b2 July 31, 2023 23:50

Merge branch 'dev' into SIMSBIOHUB-154

1446d59

al-rosenthal self-requested a review August 1, 2023 00:28

al-rosenthal previously approved these changes Aug 1, 2023

View reviewed changes

* Add support for patching verified user information

908f788

* Add keycloak user information zod schemas

NickPhura dismissed al-rosenthal’s stale review via 908f788 August 2, 2023 01:01

NickPhura added 7 commits August 2, 2023 12:38

Fix tests

20563f5

Add new keyclaok env vars

2e20d0b

Merge branch 'dev' into SIMSBIOHUB-154

7139b2c

Move update user function to user-service.

c1d10d1

Rename some keycloak interfaces

Merge branch 'SIMSBIOHUB-154' of https://github.com/bcgov/biohubbc in…

c1acf54

…to SIMSBIOHUB-154

Add missing toLowerCase call

1e0d891

ignore-skip

9b47bc2

al-rosenthal reviewed Aug 2, 2023

View reviewed changes

api/src/services/user-service.ts Outdated Show resolved Hide resolved

api/src/repositories/user-repository.ts Outdated Show resolved Hide resolved

Fix manual add system and project users workflows

275a233

NickPhura added 2 commits August 4, 2023 13:23

Merge remote-tracking branch 'origin/dev' into SIMSBIOHUB-154

4715e03

Merge adjustments

2e1ef79

NickPhura dismissed stale reviews from KjartanE and al-rosenthal via 2e1ef79 August 4, 2023 20:58

NickPhura requested review from al-rosenthal and KjartanE August 4, 2023 20:59

KjartanE previously approved these changes Aug 4, 2023

View reviewed changes

curtisupshall self-assigned this Aug 8, 2023

curtisupshall reviewed Aug 8, 2023

View reviewed changes

app/src/features/admin/users/AddSystemUsersForm.tsx Show resolved Hide resolved

Fix user patch

fbba71d

NickPhura dismissed KjartanE’s stale review via fbba71d August 9, 2023 00:29

curtisupshall previously approved these changes Aug 9, 2023

View reviewed changes

al-rosenthal previously approved these changes Aug 9, 2023

View reviewed changes

Moved some db code to db-utils and added unit tests.

f6459f9

NickPhura dismissed stale reviews from al-rosenthal and curtisupshall via f6459f9 August 9, 2023 18:35

Fix test names

7ded6b7

NickPhura requested review from curtisupshall and al-rosenthal August 9, 2023 18:37

al-rosenthal previously approved these changes Aug 9, 2023

View reviewed changes

Remove unused code.

42fe6ee

Fix code smell.

NickPhura dismissed al-rosenthal’s stale review via 42fe6ee August 9, 2023 19:01

NickPhura requested a review from al-rosenthal August 9, 2023 19:01

al-rosenthal approved these changes Aug 9, 2023

View reviewed changes

curtisupshall approved these changes Aug 10, 2023

View reviewed changes

NickPhura merged commit ae70b16 into dev Aug 10, 2023
19 of 20 checks passed

NickPhura deleted the SIMSBIOHUB-154 branch August 10, 2023 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SIMSBIOHUB-154: System user table updates #1060

SIMSBIOHUB-154: System user table updates #1060

NickPhura commented Jul 27, 2023 •

edited

Loading

github-actions bot commented Jul 27, 2023

codecov bot commented Jul 27, 2023 •

edited

Loading

github-actions bot commented Jul 31, 2023

al-rosenthal left a comment

al-rosenthal left a comment

al-rosenthal left a comment

KjartanE left a comment

curtisupshall left a comment

curtisupshall left a comment

al-rosenthal left a comment

al-rosenthal left a comment

sonarcloud bot commented Aug 9, 2023

al-rosenthal left a comment

SIMSBIOHUB-154: System user table updates #1060

SIMSBIOHUB-154: System user table updates #1060

Conversation

NickPhura commented Jul 27, 2023 • edited Loading

Links to Jira Tickets

Description of Changes

Testing Notes

github-actions bot commented Jul 27, 2023

codecov bot commented Jul 27, 2023 • edited Loading

Codecov Report

github-actions bot commented Jul 31, 2023

al-rosenthal left a comment

Choose a reason for hiding this comment

al-rosenthal left a comment

Choose a reason for hiding this comment

al-rosenthal left a comment

Choose a reason for hiding this comment

KjartanE left a comment

Choose a reason for hiding this comment

curtisupshall left a comment

Choose a reason for hiding this comment

curtisupshall left a comment

Choose a reason for hiding this comment

al-rosenthal left a comment

Choose a reason for hiding this comment

al-rosenthal left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Aug 9, 2023

al-rosenthal left a comment

Choose a reason for hiding this comment

NickPhura commented Jul 27, 2023 •

edited

Loading

codecov bot commented Jul 27, 2023 •

edited

Loading