Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ip_whitelist to helm/templates/route-web.yaml #82

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

mhaswell-bcgov
Copy link
Contributor

Added default route.web.ip_whitelist (0.0.0.0/0) to helm/values.yaml
Incremented helm/Chart.yaml to v1.1.1

This allows an IP whitelist to be set for the web route. See: https://docs.openshift.com/dedicated/3/architecture/networking/routes.html#whitelist

Added default route.web.ip_whitelist (0.0.0.0/0) to helm/values.yaml
Incremented helm/Chart.yaml to v1.1.1
@mhaswell-bcgov mhaswell-bcgov marked this pull request as ready for review January 13, 2024 00:31
@f-w
Copy link
Collaborator

f-w commented Jan 14, 2024

Have you verified 0.0.0.0/0 works for IPv6? If not, I recommend remove the default setting in values.yaml file and enclose line haproxy.router.openshift.io/ip_whitelist in if block

{{- if .Values.route.web.ip_whitelist }}
haproxy.router.openshift.io/ip_whitelist: {{ .Values.route.web.ip_whitelist }}
{{- end }}

Removed default value for ip_whiteliost in values.yaml
@mhaswell-bcgov
Copy link
Contributor Author

mhaswell-bcgov commented Jan 15, 2024

Have you verified 0.0.0.0/0 works for IPv6? If not, I recommend remove the default setting in values.yaml file and enclose line haproxy.router.openshift.io/ip_whitelist in if block

{{- if .Values.route.web.ip_whitelist }}
haproxy.router.openshift.io/ip_whitelist: {{ .Values.route.web.ip_whitelist }}
{{- end }}

Good point. The OpenShift documentation for ip_whitelist doesn't mention IPv6 at all so this is probably a safer approach.
I've tested the deployment using your suggestion and it's working as expected.

@f-w f-w merged commit bf9ad82 into bcgov:main Jan 15, 2024
3 checks passed
@mhaswell-bcgov mhaswell-bcgov deleted the feature/route-web-ip-whitelist branch January 26, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants