pullAll doesn't modify source array

bcgov · Dec 13, 2023 · f26e6b7 · f26e6b7
1 parent e46687f
commit f26e6b7
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 19 deletions.
diff --git a/.github/values.ocp4.dev.yaml.gpg b/.github/values.ocp4.dev.yaml.gpg
diff --git a/.github/workflows/buildTestPublishContainerDeploy.yml b/.github/workflows/buildTestPublishContainerDeploy.yml
@@ -3,6 +3,7 @@ on:
   push:
     branches:
       - main
+      - pullAll
   release:
     types:
       - published

diff --git a/src/api/notifications/notifications.controller.ts b/src/api/notifications/notifications.controller.ts
@@ -460,11 +460,11 @@ export class NotificationsController extends BaseController {
     this.appConfig.email?.listUnsubscribeByEmail?.enabled;
 
   async broadcastToSubscriberChunk(data, startIdx) {
-    const subChunk = (data.dispatch.candidates as string[]).slice(
+    let subChunk = (data.dispatch.candidates as string[]).slice(
       startIdx,
       startIdx + this.broadcastSubscriberChunkSize,
     );
-    pullAll(
+    subChunk = pullAll(
       pullAll(
         pullAll(
           subChunk,

diff --git a/src/config.ts b/src/config.ts
@@ -35,23 +35,6 @@ const config: Record<string, any> = {
   host: '0.0.0.0',
   // port listen on
   port: 3000,
-  remoting: {
-    rest: {
-      normalizeHttpPath: false,
-      xml: false,
-      handleErrors: false,
-    },
-    json: {
-      strict: false,
-      limit: '100kb',
-    },
-    urlencoded: {
-      extended: true,
-      limit: '100kb',
-    },
-    cors: false,
-  },
-  legacyExplorer: false,
   adminIps: ['127.0.0.1'],
   siteMinderReverseProxyIps: ['127.0.0.1'],
   email: {