Css class added for user roles in topics and replies

[robinwpdeveloper]

Fixes 2692

[robinwpdeveloper]

@JJJ can you please review this pull request.
This is my first contribution to bbPress. :)

Let me know if I am missing anything.

[JJJ]

Hello @robinwpdeveloper! 👋 This is an awesome first attempt!

I see what you are wanting here, and I think it is a good idea.

Because of how these functions are currently coded to work, there are a few different parts of your approach that could use refinement.

• Calling functions before parsing arguments is (generally) a pattern that we (almost always try to) avoid whenever possible.
• bbp_get_user_display_role() now gets called twice, before and after arguments are parsed
• I wonder if your strtolower() call should be sanitize_key() instead, or even sanitize_css_class() depending...

It's really too bad the CSS classes aren't more abstracted here. I can totally imagine customizing them being useful.

[robinwpdeveloper]

Thanks @JJJ
I have made changes accordingly as per your suggestion.
Let me know if any more changes are needed.

[rudlinkon]

sanitize_key function itself used strtolower function so we do not need to do it again.

[rudlinkon]

thank you @robinwpdeveloper it looks good to me. 👍

[mikachan]

This works well for me 👍

I've left some tiny suggestions but otherwise, I think this is ready to merge.

[robinwpdeveloper]

Thanks @mikachan for the review :)
Requested changes are made and pushed.

I think this PR is ready to commit.