Allow prefix to be set as an absolute path in configure
#1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishazharov
force-pushed
the
root-prefix
branch
from
f7eb57e
to
6df0002
Compare
snakethatlovesstaticlibs
force-pushed
the
root-prefix
branch
from
e27e147
to
d196e37
Compare
snakethatlovesstaticlibs
force-pushed
the
root-prefix
branch
from
d196e37
to
2e8ea5f
Compare
mishazharov
force-pushed
the
root-prefix
branch
from
2e8ea5f
to
cb4a90e
Compare
|
@jsharpe Can you please take a look at this PR if you have a chance? It simplified some of our build setup because binaries aren't confused about where they're being executed from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows setting the
--prefixflag to an absolute path forconfigure. Whenmakeis invoked, targets that start withinstalloruninstallare given aDESTDIRflag which instructsmaketo place the install output into the directory that the rules expect the installed files to be in.Since there could be some shortfalls with this approach of setting the
prefixflag (namely ifmakedoesn't supportDESTDIRfor some reason) this new option is specified as "experimental"Closes #823