Skip to content

Commit

Permalink
Set the LD environment variable (#1068)
Browse files Browse the repository at this point in the history
Co-authored-by: James Sharpe <[email protected]>
  • Loading branch information
dstufft and jsharpe committed Oct 14, 2023
1 parent ed89d23 commit c62e551
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions foreign_cc/private/cc_toolchain_util.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ CxxToolsInfo = provider(
cxx = "C++ compiler",
cxx_linker_static = "C++ linker to link static library",
cxx_linker_executable = "C++ linker to link executable",
ld = "linker",
),
)

Expand Down Expand Up @@ -216,6 +217,7 @@ def get_tools_info(ctx):
feature_configuration = feature_configuration,
action_name = ACTION_NAMES.cpp_link_executable,
),
ld = cc_toolchain.ld_executable,
)

def get_flags_info(ctx, link_output_file = None):
Expand Down
1 change: 1 addition & 0 deletions foreign_cc/private/make_env_vars.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ _MAKE_TOOLS = {
"AR": "cxx_linker_static",
"CC": "cc",
"CXX": "cxx",
"LD": "ld",
# missing: cxx_linker_executable
}

Expand Down

0 comments on commit c62e551

Please sign in to comment.