Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proper version sorting #148

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Implement proper version sorting #148

merged 5 commits into from
Aug 8, 2024

Conversation

Wyverald
Copy link
Collaborator

Got bored and wanted to explore Typescript.

Tested on https://typescriptlang.org/play:

> console.log(sortVersions(['1.2.3', '1.2.3-d', '1.2.3.bcr.1', '1.2.3rc3', '1', 'k']))
["k", "1.2.3rc3", "1.2.3.bcr.1", "1.2.3", "1.2.3-d", "1"]

Partially addresses #54.

Fixes #142.

@Wyverald
Implement proper version sorting
7b4d324 
Got bored and wanted to explore Typescript.

Tested on https://typescriptlang.org/play:

    > console.log(sortVersions(['1.2.3', '1.2.3-d', '1.2.3.bcr.1', '1.2.3rc3', '1', 'k']))
    ["k", "1.2.3rc3", "1.2.3.bcr.1", "1.2.3", "1.2.3-d", "1"] 

Addresses #54.

Fixes #142.
@Wyverald Wyverald requested a review from hobofan July 24, 2024 04:02
@Wyverald
Copy link
Collaborator Author

gentle ping @hobofan

@meteorcloudy
Copy link
Collaborator

Can you pleas check

Run pnpm prettier-check

> [email protected] prettier-check /home/runner/work/bcr-ui/bcr-ui
> prettier --check .

Checking formatting...
[warn] data/moduleStaticProps.ts
[warn] Code style issues found in the above file. Run Prettier to fix.
 ELIFECYCLE  Command failed with exit code 1.
 ```

@Wyverald
Copy link
Collaborator Author

Wyverald commented Aug 7, 2024

Fixed!

meteorcloudy
meteorcloudy approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@meteorcloudy meteorcloudy merged commit 6b7e40a into main Aug 8, 2024
1 check passed
@meteorcloudy meteorcloudy deleted the Wyverald-patch-1 branch August 8, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@hobofan hobofan Awaiting requested review from hobofan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with package version sorting when .bcr.* versions are involved
2 participants
@Wyverald @meteorcloudy