Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Detected code that calls async_forward_entry_setup #1029

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielbrunt57
Copy link

Fixes #1020
Change async_setup_entry to use await hass.config_entries.async_forward_entry_setups(config_entry, PLATFORMS)

Change `async_setup_entry` to use `await hass.config_entries.async_forward_entry_setups(config_entry, PLATFORMS)`
@basnijholt basnijholt enabled auto-merge (squash) August 2, 2024 06:16
@basnijholt
Copy link
Owner

It seems like CI pipelines fail. Any idea?

@danielbrunt57
Copy link
Author

danielbrunt57 commented Aug 3, 2024

It seems like CI pipelines fail. Any idea?

All those checks are new to me! I forked the repo like I've done with others in the past, made my change and submitted the PR. I've really no idea at this point what to do. The readme failure seems to be an issue with your repository? Something/something.git returned 403?
As for the yaml test failure, I dunno...

FAILED tests/components/adaptive_lighting/test_config_flow.py::test_changing_options_when_using_yaml[pyloop]

@rwjack
Copy link
Contributor

rwjack commented Aug 14, 2024

Seems like the unit tests need to be modified. If it was up to me, I wouldn't be testing anything older than a year. That means 2023.8 would be the oldest supported version. Maybe even 6 months, since this is a custom integration after all. If people want newer versions they have to keep up with HA as well...

@rwjack
Copy link
Contributor

rwjack commented Aug 14, 2024

And secondly, something is off with this piece of code https://github.com/basnijholt/adaptive-lighting/actions/runs/10209741520/workflow?pr=1029:

     - name: Push changes
        if: env.commit_status == 'committed'
        uses: ad-m/github-push-action@master
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          branch: ${{ github.head_ref }}

Perhaps your github token expired @basnijholt

@danielbrunt57
Copy link
Author

FAILED tests/components/adaptive_lighting/test_config_flow.py::test_changing_options_when_using_yaml[pyloop]

It this integration were mine, I'd deprecate using yaml config and adopt config_flow only configuration like the majority of integrations have done (HA included).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detected code that calls async_forward_entry_setup
3 participants