Add Quickstart Guide to docs.base.org/docs #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
|
@ericbrown99 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
|
cc @wbnns & @hughescoin |
wbnns
requested changes
Sep 14, 2024
There was a problem hiding this comment.
Heya! Thanks for putting this together! Left two comments in-line w/ small nits but otherwise LGTM! Can you please merge in the latest changes from master?
Also, a question -- I noticed what looked like maybe a couple of artifacts in these commit titles:
c5fdd91
3f48d4c
I didn't see any translations in this PR. PLMK if I should be looking somewhere else for the correlation here. 👍
* remove page events in favor of pageview * fix invalid logging
* Fix demo code in useWriteContract docs * Fix typos * Fix demo code * Fix import path
* error-triage.md Correction * hardhat-verify-sbs.md Correction * data.json Correction * 5_cross-chain-with-layerzero.md Correction
* initial draft of frame render * render frames from text records * fix build, https instead of * csp * undo changes to base-docs * no-verify repeat * add xmtp signer * fix build issue and add frame prompt element * Extract TryNowHero component * add second add-frame button * Frame previews in modal * Frame previews in modal * Rough out copy and text hierachy * More blocking * fix property access on profile context * add responsive layout * Setup suggestion cards * clean up pr * clean up pr * Update card icons * Make AddFrameModal components modular * fully functional farcaster frames * get previews working * polish * Target arm64 architecture for web (base-org#967) * theme update * try openframes first * wip towards frame management page * Revert "wip towards frame management page" This reverts commit de4b6eb. * Revert "Revert "wip towards frame management page"" This reverts commit 52a4555. * make page render * get desktop frame builder ui working * frame manager page w/ loading and some styles * add back button * better theme and add multi-add * fix loading experience * add mobile ux * incorporate d furlong's suggestion re: frameImage fix * dogfooding input from Rhea * improved validation and copy * improved loading state * improve button and input styling * add farcaster logout ux * clean up sign-in ux * clean up qr modal * add swap frame * clean up frame image sizing * add a nice smooth transition in/out of loading states * BAPP-579 * BAPP-585, BAPP-586 * BAPP-583 * BAPP-583 * move error handling up a level * analytics * improve mobile builder ux * fix farcaster signer modal close issue--poll for text record changes on owned profiles * center sign in with warpcast text * yarn * pr review from Leo * lint * add back nomination frame * stick buttons to the bottom and center the loader * revert csp changes * add more logging and remove dead code * be less spooky about the missing env vars * add more info to error/analytics calls * optimistic addition/removal of frames; improved warpcast sign-in * remove columns experimentation * fix masonry layout * update icons for shelley * rm unnecessary classnames call * frame border radius nit * style nits * add dropped icon * bunday review --------- Co-authored-by: Matthew Bunday <[email protected]> Co-authored-by: David Roth <[email protected]>
* add basenames frames tutorial without images * add images to asset folder * add images to tutorial * add image of profile completion * make basenames singular * update slug to lowercase b in basename * add reference links * add basenames faq question * reword what are frames paragraph * add open spec link * remove profile mentions
* update Claim Basename call to action * update grammar on intro and second paragraph * change example basename * remove UL and turn into sentences
ericbrown99
force-pushed
the
eric/quickstart-guide
branch
from
e6602d9
to
c1f16fc
Compare
|
Fixed the open items above and merged in the latest from master, thanks! Mind taking a last quick look and then LGTM 🚀 |
wbnns
previously requested changes
Sep 26, 2024
|
Review Error for wbnns @ 2024-09-26 20:21:58 UTC |
hughescoin
approved these changes
Sep 26, 2024
|
Review Error for hughescoin @ 2024-09-26 21:31:46 UTC |
hughescoin
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Added a Quickstart: Deploy on Base guide to the
Building on Basesection of the docs.The intention of this guide is to stay as high level as possible while still providing enough information for new developers to deploy contracts to Base. It uses the Foundry framework to support this process.
Notes to reviewers
Please review for correctness and consistency of language. Please follow the tutorial and ensure you are able to replicate the results by exactly following the steps outlined in the guide to ensure everyone will have success.
How has it been tested?
I tested this by spinning up a fresh directory and following the steps exactly to ensure I was able to deploy and interact with contracts from my local machine.