Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) - Update Pyth Oracle #798

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

(feat) - Update Pyth Oracle #798

wants to merge 22 commits into from

Conversation

aditya520
Copy link

What changed? Why?
Updated Pyth Oracle info.

Notes to reviewers

How has it been tested?

@vercel Vercel
Copy link

vercel bot commented Aug 7, 2024

@aditya520 is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 7, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 -1/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@vercel Vercel
Copy link

vercel bot commented Aug 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 4:51pm
web-base-docs ❌ Failed (Inspect) Oct 2, 2024 4:51pm

@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

wbnns
wbnns requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aditya520

Hi there! Thanks for the patience on this PR! Left a few comments / nits in-line, mainly related to a spacing typo and removal of superlatives.

apps/base-docs/docs/tools/oracles.md Outdated Show resolved Hide resolved
apps/base-docs/docs/tools/oracles.md Outdated Show resolved Hide resolved
apps/base-docs/docs/tools/oracles.md Outdated Show resolved Hide resolved
apps/base-docs/docs/tools/oracles.md Outdated Show resolved Hide resolved
apps/base-docs/docs/tools/oracles.md Outdated Show resolved Hide resolved
wbnns
wbnns requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aditya520 Thanks for the update! There are still a couple of superlatives and two remaining nits. Once fixed we can merge. 👍

wbnns
wbnns requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aditya520

Thanks for the update. Looks like two typos need to be fixed and then I think we're good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zencephalon zencephalon Awaiting requested review from zencephalon

@wbnns wbnns Awaiting requested review from wbnns

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aditya520 @cb-heimdall @wbnns @zencephalon