Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mainnet gas config #185

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

cody-wang-cb
Copy link
Contributor

@cody-wang-cb cody-wang-cb commented Jun 27, 2024

We want to update the gas config to recover some of the L1 fees, thus preparing this script for updating the gas config scalar.

Ran simulation locally with ledger

# blob base fee scalar: 659851
# v1 hex encoding : 0x010000000000000000000000000000000000000000000000000a118b0000044d
# uint value for the 'scalar' parameter in SystemConfigProxy.setGasConfig():
SCALAR=452312848583266388373324160190187140051835877600158453279134021569375896653
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still waiting for the new value

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new value is expected to be 452312848583266388373324160190187140051835877600158453279134021569375896970
cc @roberto-bayardo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

# blob base fee scalar: 659851
# v1 hex encoding : 0x010000000000000000000000000000000000000000000000000a118b0000044d
# uint value for the 'scalar' parameter in SystemConfigProxy.setGasConfig():
SCALAR=452312848583266388373324160190187140051835877600158453279134021569375896653
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new value is expected to be 452312848583266388373324160190187140051835877600158453279134021569375896970
cc @roberto-bayardo

Comment on lines +50 to +55
function _getNonce(IGnosisSafe safe) internal view override returns (uint256 nonce) {
uint256 _nonce = safe.nonce();
console.log("Safe current nonce:", _nonce);
console.log("Incrememnting by 1 to account for planned `Update` tx");
return _nonce + 1;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that our RollbackGasConfig contract automatically handles the nonce adjustment. We should update our future RollbackGasLimit contracts to do this instead of requiring a manual nonce config

Comment on lines 89 to 90
Before: 0x000000000000000000000000000000000000000000000000000000000000000a
After: 0x000000000000000000000000000000000000000000000000000000000000000b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect these values to be larger, likely 0x13 and 0x14.
I'd recommend simulating the transaction and updating each of these before/after values.
Likewise, the rollback would be expected to swap the before and after values for everything except the nonce

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated

@cody-wang-cb cody-wang-cb merged commit 8f72407 into main Jun 27, 2024
4 checks passed
@cody-wang-cb cody-wang-cb deleted the cody/update-mainnet-gas-config branch June 27, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants