-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mainnet gas config #185
Conversation
# blob base fee scalar: 659851 | ||
# v1 hex encoding : 0x010000000000000000000000000000000000000000000000000a118b0000044d | ||
# uint value for the 'scalar' parameter in SystemConfigProxy.setGasConfig(): | ||
SCALAR=452312848583266388373324160190187140051835877600158453279134021569375896653 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still waiting for the new value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new value is expected to be 452312848583266388373324160190187140051835877600158453279134021569375896970
cc @roberto-bayardo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
# blob base fee scalar: 659851 | ||
# v1 hex encoding : 0x010000000000000000000000000000000000000000000000000a118b0000044d | ||
# uint value for the 'scalar' parameter in SystemConfigProxy.setGasConfig(): | ||
SCALAR=452312848583266388373324160190187140051835877600158453279134021569375896653 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new value is expected to be 452312848583266388373324160190187140051835877600158453279134021569375896970
cc @roberto-bayardo
function _getNonce(IGnosisSafe safe) internal view override returns (uint256 nonce) { | ||
uint256 _nonce = safe.nonce(); | ||
console.log("Safe current nonce:", _nonce); | ||
console.log("Incrememnting by 1 to account for planned `Update` tx"); | ||
return _nonce + 1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that our RollbackGasConfig
contract automatically handles the nonce adjustment. We should update our future RollbackGasLimit
contracts to do this instead of requiring a manual nonce config
Before: 0x000000000000000000000000000000000000000000000000000000000000000a | ||
After: 0x000000000000000000000000000000000000000000000000000000000000000b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect these values to be larger, likely 0x13
and 0x14
.
I'd recommend simulating the transaction and updating each of these before/after values.
Likewise, the rollback would be expected to swap the before and after values for everything except the nonce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated
We want to update the gas config to recover some of the L1 fees, thus preparing this script for updating the gas config scalar.
Ran simulation locally with ledger