[Chore] Fix L1Resolver#addSigners

base-org · May 28, 2024 · 50d56fc · 50d56fc
1 parent 3a4b3f9
commit 50d56fc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/contracts/src/L1/L1Resolver.sol b/contracts/src/L1/L1Resolver.sol
@@ -43,7 +43,7 @@ contract L1Resolver is IExtendedResolver, ERC165, Ownable {
 
     function addSigners(address[] calldata _signers) external onlyOwner {
         for (uint256 i; i < _signers.length; i++) {
-            signers[_signers[i]] == true;
+            signers[_signers[i]] = true;
         }
         emit NewSigners(_signers);
     }

diff --git a/contracts/test/L1Resolver/AdminMethods.t.sol b/contracts/test/L1Resolver/AdminMethods.t.sol
@@ -24,11 +24,17 @@ contract AdminMethods is L1ResolverTestBase {
         vm.prank(makeAddr("0x2"));
         vm.expectRevert(abi.encodeWithSelector(Ownable.Unauthorized.selector));
         resolver.addSigners(_signers);
+        for (uint256 i; i < _signers.length; i++) {
+            assertFalse(resolver.signers(_signers[i]));
+        }
 
         vm.prank(owner);
         vm.expectEmit();
         emit L1Resolver.NewSigners(_signers);
         resolver.addSigners(_signers);
+        for (uint256 i; i < _signers.length; i++) {
+            assertTrue(resolver.signers(_signers[i]));
+        }
     }
 
     function test_removeSigner() public {