[Java21] Fix failing debugger for java 21 #43448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HindujaB
requested review from
hevayo,
warunalakshitha,
sameerajayasoma and
hasithaa
as code owners
HindujaB
requested review from
NipunaRanasinghe,
warunalakshitha and
ravinperera00
and removed request for
hevayo,
hasithaa,
sameerajayasoma and
warunalakshitha
HindujaB
commented
Oct 4, 2024
|
|
||
| // variables outside worker should not be visible | ||
| Assert.assertFalse(localVariables.containsKey("a")); | ||
| if (debugHitInfo.getKey().getLine() == 23) { |
There was a problem hiding this comment.
This fix is added because with new virtual thread implementation, the order of execution for workers is not consistent. Therefore, we can't rely on the debug point hitting order. I modified the assertions depending on which debug point hits first.
@warunalakshitha Is this expected?
| @@ -83,7 +83,7 @@ public void stackFrameDebugTest() throws BallerinaTestException { | |||
| // Stack frame representation test for strand creation with 'start' keyword. | |||
| // Results of the strand is not assigned to any variable. In this case frame name is assigned to 'anonymous'. | |||
| debugTestRunner.assertCallStack(frames[0], "sayHello", 45, "main.bal"); | |||
| debugTestRunner.assertCallStack(frames[1], "start:anonymous", 10, "main.bal"); | |||
| debugTestRunner.assertCallStack(frames[1], "start:anon", 10, "main.bal"); | |||
There was a problem hiding this comment.
Here, the default strand name is changed to anon if the future value name is not provided.
Comment on lines
1110
to
1111
| ClassPrepareRequest classPrepareRequest = erm.createClassPrepareRequest(); | ||
| classPrepareRequest.enable(); |
There was a problem hiding this comment.
Just to make it consistent with L1112 and L1113
Suggested change
| ClassPrepareRequest classPrepareRequest = erm.createClassPrepareRequest(); | |
| classPrepareRequest.enable(); | |
| ClassPrepareRequest classPrepareRequest = erm.createClassPrepareRequest().enable(); |
Comment on lines
62
to
+63
| private static final Logger LOGGER = LoggerFactory.getLogger(JDIEventProcessor.class); | ||
| private static final List<ThreadReference> virtualThreads = new ArrayList<>(); |
There was a problem hiding this comment.
Suggested change
| private static final Logger LOGGER = LoggerFactory.getLogger(JDIEventProcessor.class); | |
| private static final List<ThreadReference> virtualThreads = new ArrayList<>(); | |
| private static final Logger LOGGER = LoggerFactory.getLogger(JDIEventProcessor.class); | |
| private static final List<ThreadReference> virtualThreads = new ArrayList<>(); |
Suggested change
| private static final Logger LOGGER = LoggerFactory.getLogger(JDIEventProcessor.class); | |
| private static final List<ThreadReference> virtualThreads = new ArrayList<>(); | |
| private static final List<ThreadReference> virtualThreads = new ArrayList<>(); | |
| private static final Logger LOGGER = LoggerFactory.getLogger(JDIEventProcessor.class); | |
Comment on lines
+132
to
+145
| } else if (event instanceof ThreadStartEvent threadStartEvent) { | ||
| ThreadReference thread = threadStartEvent.thread(); | ||
| if (thread.isVirtual()) { | ||
| synchronized (virtualThreads) { | ||
| virtualThreads.add(thread); | ||
| } | ||
| } | ||
| eventSet.resume(); | ||
| } else if (event instanceof ThreadDeathEvent threadDeathEvent) { | ||
| ThreadReference thread = threadDeathEvent.thread(); | ||
| synchronized (virtualThreads) { | ||
| virtualThreads.remove(thread); | ||
| } | ||
| eventSet.resume(); |
There was a problem hiding this comment.
For the virtualThreads variable, using a ConcurrentLinkedQueue or CopyOnWriteArrayList (concurrent data structures) is generally better than using an ArrayList with explicit synchronization blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Fixes #43430
Approach
Samples
Remarks
Check List