Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate BUnionType's getMemberTypes() usages #43341

Draft
wants to merge 3 commits into
base: nutcracker
Choose a base branch
from

Conversation

lochana-chathura
Copy link
Member

@lochana-chathura lochana-chathura commented Aug 30, 2024

Purpose

$subject

Fixes #43344

Approach

n/a

Samples

n/a

Remarks

n/a

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@lochana-chathura lochana-chathura added Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Area/SemtypeIntegration Issue related to integrating semtype engine labels Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 97.18310% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.40%. Comparing base (0e984bb) to head (f8d8a47).
Report is 1 commits behind head on nutcracker.

Files with missing lines Patch % Lines
...piler/semantics/analyzer/CompilerPluginRunner.java 0.00% 1 Missing ⚠️
...compiler/semantics/analyzer/TypeParamAnalyzer.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             nutcracker   #43341      +/-   ##
================================================
- Coverage         77.41%   77.40%   -0.01%     
+ Complexity        58285    58227      -58     
================================================
  Files              3439     3439              
  Lines            219307   219168     -139     
  Branches          28808    28743      -65     
================================================
- Hits             169773   169646     -127     
  Misses            40044    40044              
+ Partials           9490     9478      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lochana-chathura lochana-chathura force-pushed the semIntegration/cleanup3 branch 2 times, most recently from 6d652a5 to dfb9b06 Compare September 4, 2024 16:44
@lochana-chathura lochana-chathura force-pushed the semIntegration/cleanup3 branch 3 times, most recently from 91ce09e to 9f71211 Compare October 1, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/SemtypeIntegration Issue related to integrating semtype engine Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant