Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public construct check for configurable variables in API doc generation #43044

Conversation

NipunaMadhushan
Copy link
Contributor

Purpose

$subject

Fixes ballerina-platform/ballerina-dev-tools#359

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

sm1990
sm1990 previously approved these changes Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.39%. Comparing base (e6b095b) to head (56ca67d).
Report is 523 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43044      +/-   ##
============================================
+ Coverage     77.20%   77.39%   +0.18%     
- Complexity    51293    58335    +7042     
============================================
  Files          2929     3453     +524     
  Lines        204407   219064   +14657     
  Branches      26664    28766    +2102     
============================================
+ Hits         157817   169543   +11726     
- Misses        38027    40182    +2155     
- Partials       8563     9339     +776     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added Stale and removed Stale labels Jul 19, 2024
@NipunaMadhushan NipunaMadhushan merged commit 51bdd8e into ballerina-platform:master Jul 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Configurable variables are not added to API docs unless they are public
4 participants