Check command buffer callback queue before VkDevice is destroyed #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baldurk
requested changes
Sep 16, 2024
There was a problem hiding this comment.
I think since this is happening during shutdown we should just destroy these events and close without calling the callbacks, as it seems safer to not call callbacks that may want to do work that's invalid while shutting down - rather than callbacks which must be called.
cmannett85-arm
force-pushed
the
flush_submit_completion_q
branch
from
40667af
to
c450950
Compare
baldurk
reviewed
Sep 17, 2024
We only check for signaled events on each queue submit, so the last submission before exit will never be checked. This change makes sure we release for completed submissions just before the device is destroyed (typically target application exit). In this case the callbacks are not called.
cmannett85-arm
force-pushed
the
flush_submit_completion_q
branch
from
c450950
to
99214f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only check for signaled events on each queue submit, so the last submission before exit will never be checked. This change makes sure we check for completed submissions just before the device is destroyed (typically target application exit).
Without this change you will get VVL warnings due to the
VkEventnot being destroyed before theVkDevice- plus anything else that the callbacks were intended to destroy.