Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan AS rebuild-on-replay: On queue submission completion events #3411

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Vulkan AS rebuild-on-replay: On queue submission completion events #3411

merged 2 commits into from
Sep 6, 2024

Commits on Sep 6, 2024

  1. Vulkan AS rebuild-on-replay: On queue submission completion events 

    If an AS build command is called on an already built AS (i.e. an update build) then we need to safely destroy the previously copied input buffers and their memory.  However at the point this happens, we do not own the command buffer so we don't know if the original data has actually been copied yet.

Using the mechanism in this patch we associate function objects with the command buffer that will be executed when the queue the command buffer is submitted to, has finished executing on the GPU.

This works by carying the function objects in command buffer and once it is submitted, we poll on a VkEvent we inserted.  Once signalled, we call the function objects in the order they were inserted.
    @cmannett85-arm
    cmannett85-arm committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d17d6eb View commit details
    Browse the repository at this point in the history

  2. Switch to a ref-counted solution

    @cmannett85-arm
    cmannett85-arm committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    4f370ac View commit details
    Browse the repository at this point in the history