Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve price impact error handling #1075

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

agualis
Copy link
Contributor

@agualis agualis commented Sep 10, 2024

Improves error handling in liquidity forms:

  • Avoids showing price impact error when there is also a simulation query error.
  • Detects specific viem network error in generic error component.
  • Avoids read-only issues in SDK.

Example of network error in Add form:

networkError

Example of Fraxtal error (already fixed) in Add form:

Fraxtal error

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 3:03pm
test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 3:03pm

lib/modules/web3/ChainConfig.tsx Outdated Show resolved Hide resolved
@garethfuller garethfuller merged commit e757dfc into main Sep 11, 2024
7 checks passed
@garethfuller garethfuller deleted the fix/improvePriceImpactErrors branch September 11, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants