fix: Use poolTokens over allTokens #3150
garethfullerchecks.yml
on: pull_request
Build
3m 51s
Lint
1m 46s
Unit-Test
1m 46s
Integration-Test
1m 46s
Annotations
12 errors and 8 warnings
|
lib/modules/pool/actions/LiquidityActionHelpers.spec.ts > detects pools requiring nested liquidity:
lib/modules/pool/actions/LiquidityActionHelpers.spec.ts#L43
AssertionError: expected false to be truthy
❯ lib/modules/pool/actions/LiquidityActionHelpers.spec.ts:43:49
|
|
Unit-Test
Process completed with exit code 1.
|
|
lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts > When adding nested liquidity for a weighted pool > has zero price impact:
lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts#L51
Error: Token 0x6b175474e89094c44da98b954eedeac495271d0f not found in array
❯ areTokensInArray node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/utils/areTokensInArray.ts:8:19
❯ validateTokensAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/utils/validateTokens.ts:16:13
❯ InputValidatorWeighted.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidatorBase.ts:60:9
❯ InputValidator.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidator.ts:61:43
❯ AddLiquidity.query node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/addLiquidity/index.ts:25:29
❯ Function.addLiquidityUnbalanced node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/priceImpact/index.ts:102:58
❯ UnbalancedAddLiquidityHandler.getPriceImpact lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts:51:65
❯ lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts:23:39
|
|
lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts > When adding nested liquidity for a weighted pool > has zero price impact:
lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts#L51
Error: Token 0x6b175474e89094c44da98b954eedeac495271d0f not found in array
❯ areTokensInArray node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/utils/areTokensInArray.ts:8:19
❯ validateTokensAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/utils/validateTokens.ts:16:13
❯ InputValidatorWeighted.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidatorBase.ts:60:9
❯ InputValidator.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidator.ts:61:43
❯ AddLiquidity.query node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/addLiquidity/index.ts:25:29
❯ Function.addLiquidityUnbalanced node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/priceImpact/index.ts:102:58
❯ UnbalancedAddLiquidityHandler.getPriceImpact lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts:51:65
❯ lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts:23:39
|
|
lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts > When adding nested liquidity for a weighted pool > with single token input:
lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts#L38
Error: Token 0x6b175474e89094c44da98b954eedeac495271d0f not found in array
❯ areTokensInArray node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/utils/areTokensInArray.ts:8:19
❯ validateTokensAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/utils/validateTokens.ts:16:13
❯ InputValidatorWeighted.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidatorBase.ts:60:9
❯ InputValidator.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidator.ts:61:43
❯ AddLiquidity.query node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/addLiquidity/index.ts:25:29
❯ UnbalancedAddLiquidityHandler.simulate lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts:38:47
❯ lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts:34:34
|
|
lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts > When adding nested liquidity for a weighted pool > with single token input:
lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts#L38
Error: Token 0x6b175474e89094c44da98b954eedeac495271d0f not found in array
❯ areTokensInArray node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/utils/areTokensInArray.ts:8:19
❯ validateTokensAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/utils/validateTokens.ts:16:13
❯ InputValidatorWeighted.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidatorBase.ts:60:9
❯ InputValidator.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidator.ts:61:43
❯ AddLiquidity.query node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/addLiquidity/index.ts:25:29
❯ UnbalancedAddLiquidityHandler.simulate lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts:38:47
❯ lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts:34:34
|
|
lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts > When adding nested liquidity for a weighted pool > with multiple token input:
lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts#L38
Error: Token 0x6b175474e89094c44da98b954eedeac495271d0f not found in array
❯ areTokensInArray node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/utils/areTokensInArray.ts:8:19
❯ validateTokensAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/utils/validateTokens.ts:16:13
❯ InputValidatorWeighted.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidatorBase.ts:60:9
❯ InputValidator.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidator.ts:61:43
❯ AddLiquidity.query node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/addLiquidity/index.ts:25:29
❯ UnbalancedAddLiquidityHandler.simulate lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts:38:47
❯ lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts:49:34
|
|
lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts > When adding nested liquidity for a weighted pool > with multiple token input:
lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts#L38
Error: Token 0x6b175474e89094c44da98b954eedeac495271d0f not found in array
❯ areTokensInArray node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/utils/areTokensInArray.ts:8:19
❯ validateTokensAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/utils/validateTokens.ts:16:13
❯ InputValidatorWeighted.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidatorBase.ts:60:9
❯ InputValidator.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidator.ts:61:43
❯ AddLiquidity.query node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/addLiquidity/index.ts:25:29
❯ UnbalancedAddLiquidityHandler.simulate lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts:38:47
❯ lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts:49:34
|
|
lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts > When adding nested liquidity for a weighted pool > builds Tx Config:
lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts#L38
Error: Token 0x6b175474e89094c44da98b954eedeac495271d0f not found in array
❯ areTokensInArray node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/utils/areTokensInArray.ts:8:19
❯ validateTokensAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/utils/validateTokens.ts:16:13
❯ InputValidatorWeighted.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidatorBase.ts:60:9
❯ InputValidator.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidator.ts:61:43
❯ AddLiquidity.query node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/addLiquidity/index.ts:25:29
❯ UnbalancedAddLiquidityHandler.simulate lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts:38:47
❯ lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts:62:39
|
|
lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts > When adding nested liquidity for a weighted pool > builds Tx Config:
lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts#L38
Error: Token 0x6b175474e89094c44da98b954eedeac495271d0f not found in array
❯ areTokensInArray node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/utils/areTokensInArray.ts:8:19
❯ validateTokensAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/utils/validateTokens.ts:16:13
❯ InputValidatorWeighted.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidatorBase.ts:60:9
❯ InputValidator.validateAddLiquidity node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/inputValidator/inputValidator.ts:61:43
❯ AddLiquidity.query node_modules/.pnpm/@balancer[email protected][email protected][email protected][email protected][email protected]/node_modules/@balancer/sdk/src/entities/addLiquidity/index.ts:25:29
❯ UnbalancedAddLiquidityHandler.simulate lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts:38:47
❯ lib/modules/pool/actions/add-liquidity/handlers/NestedAddLiquidity.handler.integration.spec.ts:62:39
|
|
lib/modules/pool/actions/remove-liquidity/handlers/NestedProportionalRemoveLiquidity.handler.integration.spec.ts > When proportionally removing liquidity for a nested pool > queries amounts out:
lib/modules/pool/actions/remove-liquidity/handlers/NestedProportionalRemoveLiquidity.handler.integration.spec.ts#L42
AssertionError: expected [ _TokenAmount{ …(5) }, …(1) ] to have a length of 4 but got 2
- Expected
+ Received
- 4
+ 2
❯ lib/modules/pool/actions/remove-liquidity/handlers/NestedProportionalRemoveLiquidity.handler.integration.spec.ts:42:31
|
|
lib/modules/pool/actions/remove-liquidity/handlers/NestedProportionalRemoveLiquidity.handler.integration.spec.ts > When proportionally removing liquidity for a nested pool > queries amounts out:
lib/modules/pool/actions/remove-liquidity/handlers/NestedProportionalRemoveLiquidity.handler.integration.spec.ts#L42
AssertionError: expected [ _TokenAmount{ …(5) }, …(1) ] to have a length of 4 but got 2
- Expected
+ Received
- 4
+ 2
❯ lib/modules/pool/actions/remove-liquidity/handlers/NestedProportionalRemoveLiquidity.handler.integration.spec.ts:42:31
|
|
Unit-Test
Unexpected input(s) 'node-version', valid inputs are ['version', 'dest', 'run_install', 'package_json_file', 'standalone']
|
|
Unit-Test
Unexpected input(s) 'node-version', valid inputs are ['version', 'dest', 'run_install', 'package_json_file', 'standalone']
|
|
Integration-Test
Unexpected input(s) 'node-version', valid inputs are ['version', 'dest', 'run_install', 'package_json_file', 'standalone']
|
|
Integration-Test
Unexpected input(s) 'node-version', valid inputs are ['version', 'dest', 'run_install', 'package_json_file', 'standalone']
|
|
Lint
Unexpected input(s) 'node-version', valid inputs are ['version', 'dest', 'run_install', 'package_json_file', 'standalone']
|
|
Lint
Unexpected input(s) 'node-version', valid inputs are ['version', 'dest', 'run_install', 'package_json_file', 'standalone']
|
|
Build
Unexpected input(s) 'node-version', valid inputs are ['version', 'dest', 'run_install', 'package_json_file', 'standalone']
|
|
Build
Unexpected input(s) 'node-version', valid inputs are ['version', 'dest', 'run_install', 'package_json_file', 'standalone']
|