Arb deployment #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds pause & unpause capability to the BCowFactory utilising OpenZeppelin's Pausable. The whenNotPaused modifier was added to the internal _newBPool function. This makes creating new BCowPools only possible when the factory is unpaused.
Pausing and Unpausing is made possible by exposing the external pause and unpause functions.
The entity allowed to pause and unpause is hardcoded to be the Balancer DAO multisig at 0xaF23DC5983230E9eEAf93280e312e57539D098D0 (Arbitrum) and is set at deployment time. Similar DAO multisig addresses have been set for the respective network in the deploy script.
Pausing and unpausing the factory has no impact on existing BCowPools.