Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment: ComposableStablePool V5 #61

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Deployment: ComposableStablePool V5 #61

merged 5 commits into from
Jul 11, 2023

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Jul 11, 2023

Deployment: ComposableStablePool V5

Deployment tasks checklist:

  • Contract(s) deployed to all target networks / testnets
  • TX IDs are properly generated
  • Action IDs are generated after deployment (if applicable)
  • Outputs for all target networks are generated, and linked in the task readme
  • Addresses files are up to date with the new deployment
  • Contracts are verified in every network --> Pool not verified in ZKEVM.
  • Deployments CHANGELOG is updated
  • There are no code changes of any kind

Issue Resolution

N/A

@jubeira jubeira requested a review from EndymionJkb July 11, 2023 21:44
EndymionJkb
EndymionJkb previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs the /outputs linked in the readme (and I had one comment about the changelog). Otherwise LGTM if we can get CI to pass.

CHANGELOG.md Outdated Show resolved Hide resolved
@jubeira jubeira requested a review from EndymionJkb July 11, 2023 22:07
EndymionJkb
EndymionJkb approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now; just waiting on CI.

@jubeira jubeira merged commit 90112c4 into master Jul 11, 2023
25 checks passed
@jubeira jubeira deleted the deployment/csp-v5 branch July 11, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndymionJkb EndymionJkb EndymionJkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jubeira @EndymionJkb