fix: Add missing gyro3 to SupportedRawPoolTypes. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoguerios
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
I'm struggling to identify where this SupportedRawPoolTypes is being used.
Are we limiting the code in any aspect based on those supported types?
I ask that because this didn't show up on my tests. In other words, it seems to not have any impact on the code 🤔
Am I missing something?
|
I'm actually using it externally in the API here. I assume its the best option but if there's an alternative maybe we can remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.