Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep amp accuracy in enrichment #81

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Conversation

johngrantuk
Copy link
Member

Updating test block number in #73 leads to existing tests failing. For the new block a different swap path is being found. The new CS amp value is such that the loss of accuracy during enrichment leads to errors during future calculations.

  • Update block no in test to replicate issue seen in Update balancerPoolDataQueries to latest contract code #73
  • Update amp parsing during enrichment
  • Update OnChainPoolDataEnricher config in test to load Amp for ComposableStable pools because SG value was incorrect (Maybe this should be a default?)

@mikemcdonald mikemcdonald merged commit 843a12e into main Jul 6, 2023
4 checks passed
@mikemcdonald mikemcdonald deleted the fix-amp-accuracy branch July 6, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants