Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add buffer support to swaps. #348

Merged
merged 8 commits into from
Aug 7, 2024
Merged

feat: Add buffer support to swaps. #348

merged 8 commits into from
Aug 7, 2024

Conversation

johngrantuk
Copy link
Member

WIP - Needs updated for deploy6 with query/swap fixes.

Add buffer support. Assumes SOR will add additional field: isBuffer: boolean[] as part of Path return. Each isBuffer array item at index, i, should indicate if corresponding pool in pools[i] is a buffer pool. If not returned/undefined we assume there are no buffers in swap path.

@johngrantuk johngrantuk linked an issue Jul 9, 2024 that may be closed by this pull request
@johngrantuk johngrantuk marked this pull request as ready for review August 6, 2024 10:19
Copy link
Member

@brunoguerios brunoguerios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments on variable naming, but other than that LGTM ✅

test/lib/utils/swapHelpers.ts Outdated Show resolved Hide resolved
src/abi/index.ts Outdated Show resolved Hide resolved
@johngrantuk johngrantuk merged commit 92abf28 into main Aug 7, 2024
4 checks passed
@johngrantuk johngrantuk deleted the buffer-support branch August 7, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swaps Buffer Support
2 participants