Fix bug in apropos REPL commands #481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug described in bakpakin#462 by stripping `_.G` from the input rather than the output of the `apropos*` function.
|
Looks great; thanks! I've applied your patch using git instead of using github's flow, so it doesn't register as merged, but it is there. I think I will leave #462 open because while this does allow apropos to find the function in question, it shows under Thanks again. |
|
Awesome thanks! Is there another place that would be more intuitive to find it under? Or are you just suggesting that that part be stripped from the output string? |
|
Yeah, I just meant the prefix should be excluded since anyone in the repl would be able to access those values by just typing them directly in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug described in #462 by stripping
_.Gfrom the input rather than the output of theapropos*function. This appears to have been the original intended behavior as described by the comment on line 206.