Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font to docs #10492

Closed
wants to merge 1 commit into from
Closed

Add font to docs #10492

wants to merge 1 commit into from

Conversation

rivercory
Copy link

Added Poppins font for better readability!

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @rivercory!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against 28c7546

@chris48s
Copy link
Member

chris48s commented Sep 3, 2024

I think the choice docusaurus/infima have made (defaulting to system-ui) is really good as it makes it look "native" on a range of platforms. I don't see a good reason to diverge from that.
https://github.com/facebookincubator/infima/blob/450b41af48b2d4b670a483228b59360553885e3b/packages/core/styles/common/variables.pcss#L115-L117
I'll leave this open for a bit in case another maintainer wants to strongly disagree with me.

(If we were to change this, we should not use fonts.googleapis.com. We should pull in from https://www.npmjs.com/package/@fontsource/poppins and provide some more thoughtful fallbacks but lets not get bogged down in that for now)

@chris48s chris48s added the frontend The React app and the infrastructure that supports it label Sep 4, 2024
@PyvesB
Copy link
Member

PyvesB commented Sep 7, 2024

I think the choice docusaurus/infima have made (defaulting to system-ui) is really good as it makes it look "native" on a range of platforms. I don't see a good reason to diverge from that.

Agreed!

@rivercory rivercory closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The React app and the infrastructure that supports it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants