Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish linux/amd64 docker images for snapshot builds only #10476

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

smashedr
Copy link
Contributor

@smashedr smashedr commented Aug 25, 2024

I did some research and it seems the correct way to publish a multi-architecture build under a single tag is to do it simultaneously.

0 shane@jammy [/home/shane]$ docker pull shieldsio/shields:next
next: Pulling from shieldsio/shields
no matching manifest for linux/amd64 in the manifest list entries

That will make the entire build take the full duration of ~35 minutes. At a glance I don't see master being merged to more frequently than 35 minutes apart, so I have also included the next build here, but that can easily be removed.

Copy link
Contributor

github-actions bot commented Aug 25, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @smashedr!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against fd7dbab

@smashedr smashedr marked this pull request as ready for review August 25, 2024 20:29
@chris48s
Copy link
Member

Merging lots of PRs close together is something we do frequently e.g:

Screenshot at 2024-08-26 21-57-45

Even if we didn't, having to wait ~35 minutes from merging something to having an image ready to deploy every time is just going to be too annoying. I think if the only way to do this is to push both together, we go with what I suggested in #10441 (comment) - arm64 on snapshot tags only.

@smashedr
Copy link
Contributor Author

Ok, I can remove the arm64 from next, and just leave it on the release branch build.

smashedr and others added 2 commits August 26, 2024 17:45
# Conflicts:
#	.github/workflows/create-release.yml
#	.github/workflows/publish-docker-next.yml
@chris48s chris48s changed the title Revert Matrix Build on Docker Publish linux/amd64 docker images for snapshot builds only Sep 2, 2024
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I am planning to do the next snapshot release later today so we'll test the process and (hopefully) have a working dual arch image available this time.

@chris48s chris48s added this pull request to the merge queue Sep 2, 2024
Merged via the queue into badges:master with commit 0ec667c Sep 2, 2024
25 checks passed
@chris48s
Copy link
Member

chris48s commented Sep 2, 2024

Screenshot at 2024-09-02 16-03-11

@smashedr
Copy link
Contributor Author

smashedr commented Sep 2, 2024

Looks good ✅
I was able to run shieldsio/shields:server-2024-09-02 on my development server and deploy it to my arm64 swarm server.

@chris48s chris48s added operations Hosting, monitoring, and reliability for the production badge servers self-hosting Discussion, problems, features, and documentation related to self-hosting Shields labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operations Hosting, monitoring, and reliability for the production badge servers self-hosting Discussion, problems, features, and documentation related to self-hosting Shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants