Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and tests to [docsrs] #10240

Merged

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Jun 8, 2024

Updates the main tutorial and the service-tests one to use our Docs.rs service instead of the no longer existing Wercker service. It's a nice an simple service with everything publicly available. Closes #2423.

One of the error behaviours changed on the upstream API, I've also updated the implementation and tests to reflect that.

@PyvesB PyvesB added service-badge Accepted and actionable changes, features, and bugs documentation Developer and end-user documentation labels Jun 8, 2024
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against 36ae56f

@PyvesB PyvesB force-pushed the update-tutorial-and-service-tests-to-docsrs branch from b9e4f16 to 3b4f543 Compare June 8, 2024 08:45
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor points to follow up, but I'm on-board with this. Good to update these docs to use a more relevant example.

Also closes a long-standing issue #2423 😄

doc/service-tests.md Outdated Show resolved Hide resolved
doc/service-tests.md Outdated Show resolved Hide resolved
@chris48s chris48s added this pull request to the merge queue Jun 10, 2024
Merged via the queue into badges:master with commit 8698fa1 Jun 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Developer and end-user documentation service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TUTORIAL.md: Replace Wercker with some public service API
2 participants