Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bitbucket invalid response #10155

Closed
wants to merge 1 commit into from
Closed

fix bitbucket invalid response #10155

wants to merge 1 commit into from

Conversation

shiraz-mian
Copy link

Fixes #10137

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Warnings
⚠️ This PR modified service code for bitbucket but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @shiraz-mian!

Generated by 🚫 dangerJS against 5936845

@chris48s
Copy link
Member

chris48s commented May 11, 2024 •
edited
Loading

Thanks, but this change would not fix this issue. The schema would still reject a response containing objects without a result key at the validation stage.

I've submitted a PR for this bug at #10163

@chris48s chris48s closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bitbucket not completely finished workflow returns invalid response data
2 participants
@shiraz-mian @chris48s