Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run tests on node 22 #10127

Merged
merged 1 commit into from
May 6, 2024
Merged

run tests on node 22 #10127

merged 1 commit into from
May 6, 2024

Conversation

chris48s
Copy link
Member

Node 22 is now out 🎉

We should migrate to node 22 at some point, but for the moment lets just start running the tests against it in preparation. I'll also do some testing with it when I'm developing locally.

@chris48s chris48s added operations Hosting, monitoring, and reliability for the production badge servers dependencies Related to dependency updates labels Apr 29, 2024
Copy link
Contributor

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against ad2fe1f

@chris48s
Copy link
Member Author

need to update the branch protection rules when I merge this

@LitoMore
Copy link
Contributor

LitoMore commented May 3, 2024

uses: actions/setup-node@v3

This can be upgraded to v4.

@chris48s
Copy link
Member Author

chris48s commented May 6, 2024

This can be upgraded to v4

It can, but this has made me realise that dependabot should have bumped it and it didn't. I've raised a separate issue about this - #10135

Think I'm going to leave that occurrence of actions/setup-node where it is for now as we don't need to upgrade the action for this PR and it will be useful to have dependabot bump it to confirm the new config works when I get a chance to look at that issue.

@chris48s chris48s merged commit 96525e5 into badges:master May 6, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependency updates operations Hosting, monitoring, and reliability for the production badge servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants