Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'Innkeeper' location #35

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

Ho2x
Copy link

@Ho2x Ho2x commented Aug 26, 2022

I changed the position of 'Innkeeper' because it was in front of 'Herbalism Trainer'

I changed the position of 'Innkeeper' because it was in front of 'Herbalism Trainer'
@pangolp
Copy link

pangolp commented Apr 7, 2024

Sorry for the delay, as modifications have been made to the module to make it compile, I will test the changes, resolve the conflicts and we will see that this change merges. However, to avoid, that people who are already using the module, do not check the update, I think we need to add a second file, and make the change in it. Not edit the original, because this is something I don't know, and maybe someone wants to correct me, if the module is already being used, maybe that person is left without the modification. Unless I change the hasd somehow, and re-run the change, but I really don't know if it works that way. I prefer to create a second file, and avoid that problem (just in case).

@pangolp
Copy link

pangolp commented Apr 8, 2024

We have performed tests. Thank you for your input. The change was made in the future spawns, but we also had to correct the spawns of the creatures that already existed in the creature table.

@pangolp pangolp merged commit d2a5ffe into azerothcore:master Apr 8, 2024
1 check passed
@pangolp
Copy link

pangolp commented Apr 8, 2024

Thanks @Ho2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants