Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop AC-unrelated code within #if blocks #186

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sudlud
Copy link
Member

@sudlud sudlud commented Jul 7, 2024

No description provided.

@55Honey
Copy link
Member

55Honey commented Jul 14, 2024

What happened to Shade of Aran? 🙈

/home/runner/work/mod-eluna/mod-eluna/src/server/scripts/EasternKingdoms/Karazhan/boss_shade_of_aran.cpp:127:27: fatal error: comparison of integers of different signs: 'int' and 'std::vector::size_type' (aka 'unsigned long') [-Wsign-compare]
        for (int i = 0; i < immuneSpells.size(); i++)
                        ~ ^ ~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [src/server/scripts/CMakeFiles/scripts.dir/build.make:1994: src/server/scripts/CMakeFiles/scripts.dir/EasternKingdoms/Karazhan/boss_shade_of_aran.cpp.o] Error 1

@sudlud
Copy link
Member Author

sudlud commented Jul 14, 2024

What happened to Shade of Aran? 🙈

/home/runner/work/mod-eluna/mod-eluna/src/server/scripts/EasternKingdoms/Karazhan/boss_shade_of_aran.cpp:127:27: fatal error: comparison of integers of different signs: 'int' and 'std::vector::size_type' (aka 'unsigned long') [-Wsign-compare]

        for (int i = 0; i < immuneSpells.size(); i++)

                        ~ ^ ~~~~~~~~~~~~~~~~~~~

1 error generated.

make[2]: *** [src/server/scripts/CMakeFiles/scripts.dir/build.make:1994: src/server/scripts/CMakeFiles/scripts.dir/EasternKingdoms/Karazhan/boss_shade_of_aran.cpp.o] Error 1

I'll re-run CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants