Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup! Rename flight speed related auras #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sogladev
Copy link

Changes Proposed:

Image

right have same 2 || player->HasAuraType(SPELL_AURA_MOD_FLIGHT_SPEED_ALWAYS)

Originally posted by @kissingers in 935f441

should be

206 SPELL_AURA_MOD_INCREASE_VEHICLE_FLIGHT_SPEED -> SPELL_AURA_MOD_INCREASE_FLIGHT_SPEED

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

How to Test the Changes:

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant