feat(config): Split thresholds into their own report types #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! It contains config changes !!!
View the
conf/Anticheat.conf.dist
file to see the config changes.Changes Proposed:
[ANTICHEAT ALERT]: [Awfulandterriblegnome] - Latency: 19 ms
.Anticheat.AlertFrequency
forAnticheat.AlertFrequency.Speed
and every other report types.Anticheat.ReportinChat.Min
forAnticheat.ReportInChatThreshold.Min.Speed
and every other report types. It should had capitalized the "in" part ofReportinChat
. It should had also specified that it was a threshold.Anticheat.ReportinChat.Max
.Anticheat.ReportsForIngameWarnings
for being redundant withAnticheat.ReportinChat.Min
and max.GetReportNameFromReportType
for getting a text equivalent of the currentReportTypes
.BuildAndSendReportToIngameGameMasters
. This will remove the need to type more code every time we wish to send an alert to the game masters.locale_frFR
inacore_string
.acore_string
. Thanks to @Nefertumm !_alertFrequency
(inherited from the just removed configAnticheat.AlertFrequency
) and_counter
as they were used as a total of reports instead of report specific for the purpose of alerting the game master.Issues Addressed:
Tests Performed:
Blink
above a pool of water on a flying mount #111How to Test the Changes:
Anticheat.EnabledOnGmAccounts = 1
and start doing spooky cheat stuff.Known Issues and TODO List:
COUNTER_MEASURES_REPORT
fromenum ReportTypes
as it is not a hack.How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.