-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FilterX: fix invalid LogMessage variables access #333
Open
OverOrion
wants to merge
9
commits into
axoflow:main
Choose a base branch
from
OverOrion:filterx-context-scope-fix-minimal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FilterX: fix invalid LogMessage variables access #333
OverOrion
wants to merge
9
commits into
axoflow:main
from
OverOrion:filterx-context-scope-fix-minimal
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OverOrion
force-pushed
the
filterx-context-scope-fix-minimal
branch
7 times, most recently
from
October 15, 2024 15:40
e359d69
to
8bef0ba
Compare
Signed-off-by: Szilard Parrag <[email protected]>
OverOrion
force-pushed
the
filterx-context-scope-fix-minimal
branch
2 times, most recently
from
October 16, 2024 07:42
635b6f6
to
3dd8481
Compare
Signed-off-by: Szilard Parrag <[email protected]>
This is to better indicate the intention of synchronizing FilterX -> LogMessage. Signed-off-by: Szilard Parrag <[email protected]>
OverOrion
force-pushed
the
filterx-context-scope-fix-minimal
branch
from
October 16, 2024 14:48
7dc6233
to
e67d698
Compare
…rection Signed-off-by: Szilard Parrag <[email protected]>
This will be used in _update_repr as that method should update variables with new values regardless of their current value's validity. Signed-off-by: Szilard Parrag <[email protected]>
This is required as _update_repr should update values regardless of their current validity. Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
These type of variables should only be returned if they are in sync with the scope (log_msg_has_changes flag is FALSE). Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
OverOrion
force-pushed
the
filterx-context-scope-fix-minimal
branch
from
October 17, 2024 11:25
e67d698
to
88b4238
Compare
OverOrion
changed the title
filterx context scope fix minimal
FilterX: fix invalid LogMessage variables access
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes accessing
LogMessage
type FilterX variables in case there had been changes betweenfilterx
blocks.