WIP: Implement rfc6587 auto detection #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alltilla
reviewed
Jun 12, 2024
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
98435b3
to
c728d0a
Compare
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
c728d0a
to
902b563
Compare
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
902b563
to
6c992ba
Compare
|
This should wait until #156 is merged. |
Signed-off-by: Balazs Scheidler <[email protected]>
…transport Signed-off-by: Balazs Scheidler <[email protected]>
…port() Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
These are interdependent interfaces and LogTransportStack will be the sole user of LogTransportFactory. Signed-off-by: Balazs Scheidler <[email protected]>
Instead of relying on the factory to initialize name, initialize it through the normal constructor path. Signed-off-by: Balazs Scheidler <[email protected]>
…a stack of LogTransports Instead of trying to reuse the LogTransport interface and hide cases where we need multiple swappable LogTransports, let's introduce a LogTransportStack, that explicitly tracks all such LogTransports, takes care of their lifecycle and allows them to be swapped during a connection. To be used for HA Proxy protocol support. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
This patch is based on the LogTransport implementation in github.com/syslog-ng/syslog-ng, which in turn is based on my original implementation of proxy support as a LogProto class. Signed-off-by: Alex Becker <[email protected]> Signed-off-by: Hofi <[email protected]> Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Alex Becker <[email protected]> Signed-off-by: Hofi <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…roxied' loggen parameter Signed-off-by: Hofi <[email protected]>
…e loggen with proper `proxied` switches Signed-off-by: Hofi <[email protected]>
…e is 0 Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…lected Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
6c992ba
to
e87919d
Compare
bazsi
changed the title
|
I have now rebased it but still need to check if it works on top of #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty common misconfiguration that should be handled automatically.
Open questions were resolved this way: