Event delay metric transformation #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
|
The CI is green, but a unit test silently failed due to a bug in my code. I'm fixing it. See #16 |
MrAnno
force-pushed
the
event-delay-metrics
branch
from
8775ecf
to
bcb1321
Compare
orymate
reviewed
Feb 27, 2024
Signed-off-by: László Várady <[email protected]>
Metrics are protobuf structs, they contain internal state, which should not be compared. For example, a simple `fmt.Sprint(metric.Label)` call can change the internal state of `metric`. Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
event-delay-metrics
branch
from
bcb1321
to
342649d
Compare
Signed-off-by: László Várady <[email protected]>
MrAnno
requested review from
orymate,
siliconbrain and
bshifter
and removed request for
siliconbrain and
orymate
orymate
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves axoflow/axoflow#1016