Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] shared base MSM many #27

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

jonathanpwang
Copy link
Collaborator

An untested hypothesis is that when the number of columns is high, the current version of doing best_multiexp one column at a time is not optimal because it is not memory local and doesn't use the fact that the base of the MSM is always the same (namely the KZG params).

This is a quick edit so that for a batch of columns, when we commit_lagrange we do all MSM for a chunk of the bases in a single thread.

Haven't tested it on any wide circuits to compare.

@jonathanpwang
Copy link
Collaborator Author

edit: tried keccak_bits and on my laptop (Arm, better memory) it is worse than main which just uses rayon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant