Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor gmp express example #143

Merged
merged 15 commits into from
Aug 25, 2023
Merged

Conversation

npty
Copy link
Member

@npty npty commented Aug 14, 2023

Description

This PR modifies the Call Contract with Token (Express) example. It now aligns with our updated express flow, which no longer requires the GMP Express Service. The example also shows how we compute the express fee.

For testnet runs, the script interacts with the contract at 0x22a214c3c2C23a370414e2A4b2CF829A76c29A1b. It supports both Polygon and Avalanche— our default networks for examples. Users can directly run the example without deploying, this is due to whitelisting limitation.

https://axelarnetwork.atlassian.net/browse/AXE-1303

@npty npty force-pushed the chore/refactor-gmp-express-example branch from 4367208 to 079bed2 Compare August 15, 2023 03:55
@npty npty force-pushed the chore/refactor-gmp-express-example branch from 16f536c to 24baec8 Compare August 15, 2023 04:58
@StephenFluin
Copy link
Contributor

Users can directly run the example without deploying, this is due to whitelisting limitation.

They can run the example, or can't run the example? How do they get on the allow list?

@npty
Copy link
Member Author

npty commented Aug 15, 2023

Users can directly run the example without deploying, this is due to whitelisting limitation.

They can run the example, or can't run the example? How do they get on the allow list?

They need to ask us to whitelist their contract address. That's probably too much for user if they just want to try executing it to see how it works.

So, we just deployed the contracts and whitelisted them, and they can just execute the example without deploying it.

@npty npty merged commit a1f4259 into main Aug 25, 2023
1 check passed
@npty npty deleted the chore/refactor-gmp-express-example branch August 25, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants