Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(axelarnet): archive failed transfer #2200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haiyizxx
Copy link
Contributor

@haiyizxx haiyizxx commented Oct 21, 2024

Description

AXE-5726

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@haiyizxx haiyizxx marked this pull request as ready for review October 21, 2024 20:51
@haiyizxx haiyizxx requested a review from a team as a code owner October 21, 2024 20:51
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 39.17%. Comparing base (e122d6e) to head (9baf703).

Files with missing lines Patch % Lines
x/axelarnet/keeper/msg_server.go 80.95% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2200      +/-   ##
==========================================
- Coverage   39.22%   39.17%   -0.05%     
==========================================
  Files         373      373              
  Lines       37224    37229       +5     
==========================================
- Hits        14600    14584      -16     
- Misses      21690    21712      +22     
+ Partials      934      933       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fish-sammy
Copy link
Contributor

How does retry work if failed transfers are now archived?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants