added app-registry module #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivasreddych
force-pushed
the
feat/app-registry
branch
from
0cb40fa
to
c145cb9
Compare
srinivasreddych
force-pushed
the
feat/app-registry
branch
from
c145cb9
to
27d8e21
Compare
dgraeber
reviewed
Sep 5, 2023
| commands: | ||
| - cdk deploy --require-approval never --progress events --app "python app.py" --outputs-file ./cdk-exports.json | ||
| # Export metadata | ||
| - export SEEDFARMER_MODULE_METADATA=$(python -c "import json; file=open('cdk-exports.json'); print(json.load(file)['${SEEDFARMER_PROJECT_NAME}-${SEEDFARMER_DEPLOYMENT_NAME}-${SEEDFARMER_MODULE_NAME}']['metadata'])") |
There was a problem hiding this comment.
why not start using the helper commands?
There was a problem hiding this comment.
- seedfarmer metadata convert -f cdk-exports.json || true
or
- export DEPMOD=$(seedfarmer metadata depmod)
- seedfarmer metadata convert -jq .${DEPMOD}.metadata || true
There was a problem hiding this comment.
because i load the env var SEEDFARMER_MODULE_METADATA in my python script, and grab the AppRegistry details
dgraeber
reviewed
Sep 5, 2023
dgraeber
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
added app-registry module
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.