Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored docker images replication to idf #16

Merged
merged 6 commits into from
Jun 26, 2023
Merged

refactored docker images replication to idf #16

merged 6 commits into from
Jun 26, 2023

Conversation

srinivasreddych
Copy link
Contributor

@srinivasreddych srinivasreddych commented Jun 13, 2023 •
edited
Loading

refactored docker images replication to idf with unit-tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srinivasreddych srinivasreddych marked this pull request as draft June 13, 2023 23:15
@srinivasreddych srinivasreddych marked this pull request as ready for review June 26, 2023 15:54
@srinivasreddych
Copy link
Contributor Author 

---------- coverage: platform darwin, python 3.9.1-final-0 -----------
Name                            Stmts   Miss  Cover
---------------------------------------------------
helmparser/__init__.py              0      0   100%
helmparser/arguments.py             9      0   100%
helmparser/helm/__init__.py         0      0   100%
helmparser/helm/commands.py        25      0   100%
helmparser/logging.py              10      0   100%
helmparser/parser/__init__.py       0      0   100%
helmparser/parser/parser.py        61      0   100%
helmparser/utils/utils.py           8      0   100%
---------------------------------------------------
TOTAL                             113      0   100%

Required test coverage of 80% reached. Total coverage: 100.00%

@srinivasreddych srinivasreddych marked this pull request as draft June 26, 2023 19:35
@srinivasreddych srinivasreddych marked this pull request as ready for review June 26, 2023 20:30
@srinivasreddych srinivasreddych force-pushed the feat/dockerimages-replication-ut branch from 3a19cbc to d9bf290 Compare June 26, 2023 20:33
@srinivasreddych srinivasreddych force-pushed the feat/dockerimages-replication-ut branch 2 times, most recently from 1660b9c to 09c576d Compare June 26, 2023 21:14
@srinivasreddych srinivasreddych force-pushed the feat/dockerimages-replication-ut branch from 09c576d to 1980534 Compare June 26, 2023 21:15
dgraeber
dgraeber approved these changes Jun 26, 2023
View reviewed changes
manifests/local/replicator-modules.yaml
dataFiles:
- filePath: data/eks_dockerimage-replication/versions/1.25.yaml
- filePath: data/eks_dockerimage-replication/versions/default.yaml
parameters:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is replication needed here?

manifests/local/deployment.yaml Outdated
@@ -9,6 +9,8 @@ groups:
path: manifests/local/networking-modules.yaml
- name: storage
path: manifests/local/storage-modules.yaml
- name: replication
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why replication module?

@srinivasreddych srinivasreddych merged commit bd87ca6 into awslabs:main Jun 26, 2023
8 checks passed
@srinivasreddych srinivasreddych deleted the feat/dockerimages-replication-ut branch June 26, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgraeber dgraeber dgraeber approved these changes

@chamcca chamcca Awaiting requested review from chamcca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srinivasreddych @dgraeber