Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requester Pays option [WIP] #43

Open
wants to merge 3 commits into
base: v2-alpha
Choose a base branch
from
Open

Conversation

benyanke
Copy link

@benyanke benyanke commented Mar 6, 2019

*Issue #41

Description of changes:
Implements Requester pays support.

  • Implement hard-coded requester pays
  • Test all methods extensively
  • Implement config handler to enable or disable the previously hardcoded values.
  • Clean up code and comments for merge

@benyanke
Copy link
Author

benyanke commented Mar 8, 2019

Hardcoded methods are complete. Cursory testing of downloading and browsing seems to work.

Need to set up a dedicated bucket to heavily test all methods before I can implement the configuration option.

@john-aws
Copy link
Contributor

Hi @benyanke, just wanted to check in with you on your intentions around this PR. Is the enhancement complete from your perspective, or were you planning more changes? Thanks for your efforts, by the way, really appreciated.

@benyanke
Copy link
Author

My use for it at work was deprioritized due to some other projects, so I haven't had much time to work on it lately.

At this point, it's hardcoded to use requester pays. However, it shouldn't be much more work for someone to connect to the boolean checkbox to enable/disable.

Feel free to finish that piece up and merge if you'd like, otherwise I can do it when the project requiring it at work needs it.

@wparad
Copy link

wparad commented Aug 31, 2021

@benyanke, I've since forked this repo and added RequestorPays for a lot of the requests, I don't know if everything is covered, but if the new explorer, missed one, we are planning on active maintenance: https://github.com/rhosys/aws-s3-explorer/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants