Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts to build s3-benchrunner-cli #14

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Scripts to build s3-benchrunner-cli #14

merged 9 commits into from
Oct 3, 2023

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Oct 3, 2023

Description of changes:

  • new build.py script for CLI runner
    • pull aws-cli and aws-crt-python from Github, installs them to a python virtual environment
  • new README.md for CLI runner
  • Move some copy/pastey stuff to common scripts:
    • fetch-git-repos.py: I needed this logic a 3rd time, so now it's in a helper script
    • install-tools-AL2023.py: Decided to just have 1 script for the whole repo, instead of 1 per runner.
      • They were getting too copy/pastey, with a lot of overlap in the tools they need

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@graebm graebm merged commit 7a5142e into main Oct 3, 2023
4 checks passed
@graebm graebm deleted the cli-build branch October 3, 2023 17:20
@graebm graebm mentioned this pull request Oct 18, 2023
graebm added a commit that referenced this pull request Oct 18, 2023
Cut down on boilerplate by just having one python runner, instead of separate folders, each with their own build scripts, main functions, and bytes_to_GiB() helper functions, etc, etc, etc

This looks like a crap ton of new code, but it's just moving/splitting/combingin code from the following PRs:
- #12
- #14
- #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants