-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bumping jsii from 1.77.0 to 5.1.9 #1075
Conversation
35d0f24
to
7aeefd0
Compare
7aeefd0
to
2f7b404
Compare
...components/deadline/deadline_05_secretsManagement/test/deadline_05_secretsManagement.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here, @edwards-aws! Just a few minor suggestions
packages/aws-rfdk/lib/lambdas/nodejs/asg-attach-eni/test/test.ts
Outdated
Show resolved
Hide resolved
2f7b404
to
2751e42
Compare
Updated jsii and fixed issues that came up from that. jsii requires at least Node.js 16. 16 is EOL soon, so change minimum required version to 18.
2751e42
to
4c9f438
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with this big migration and keeping the RFDK up-to-date. Thanks for all the effort here, @edwards-aws!
Updated jsii and fixed issues that came up from that.
jsii got more strict about typing during compilation mostly about using errors in catches without first checking its type.
To test this change I ran the ./build.sh script, I also ran yarn run build in each of the example directories to make sure those built as well. I also deployed ./examples/deadline/All-In-AWS-Infrastructure-Basic for TypeScript and Python and ensured that it was deployed correctly.
The new version of jsii also dropped support for Node 14. So I had to make changes to the integ tests to support Node >= 16. The main issues were related to npm changing the working directory to the directory with
package.json
in it. This broke some scripting that used relative paths.To test these changes I ran the full integ test suite and ensure all tests passed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license