chore(deps): bumping jsii from 1.77.0 to 5.1.9 #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwards-aws
force-pushed
the
edwards/update_jsii
branch
2 times, most recently
from
35d0f24
to
7aeefd0
Compare
edwards-aws
force-pushed
the
edwards/update_jsii
branch
from
7aeefd0
to
2f7b404
Compare
ddneilson
requested changes
Aug 16, 2023
...components/deadline/deadline_05_secretsManagement/test/deadline_05_secretsManagement.test.ts
Outdated
Show resolved
Hide resolved
jusiskin
requested changes
Aug 17, 2023
There was a problem hiding this comment.
Great work here, @edwards-aws! Just a few minor suggestions
packages/aws-rfdk/lib/lambdas/nodejs/asg-attach-eni/test/test.ts
Outdated
Show resolved
Hide resolved
jusiskin
added
the
breaking-change
edwards-aws
force-pushed
the
edwards/update_jsii
branch
from
2f7b404
to
2751e42
Compare
Updated jsii and fixed issues that came up from that. jsii requires at least Node.js 16. 16 is EOL soon, so change minimum required version to 18.
edwards-aws
force-pushed
the
edwards/update_jsii
branch
from
2751e42
to
4c9f438
Compare
jusiskin
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Great job with this big migration and keeping the RFDK up-to-date. Thanks for all the effort here, @edwards-aws!
ddneilson
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated jsii and fixed issues that came up from that.
jsii got more strict about typing during compilation mostly about using errors in catches without first checking its type.
To test this change I ran the ./build.sh script, I also ran yarn run build in each of the example directories to make sure those built as well. I also deployed ./examples/deadline/All-In-AWS-Infrastructure-Basic for TypeScript and Python and ensured that it was deployed correctly.
The new version of jsii also dropped support for Node 14. So I had to make changes to the integ tests to support Node >= 16. The main issues were related to npm changing the working directory to the directory with
package.jsonin it. This broke some scripting that used relative paths.To test these changes I ran the full integ test suite and ensure all tests passed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license