Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user provided SSE-C arguments to CompleteMultipartUpload call #8235

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

nateprewitt
Copy link
Member

@nateprewitt nateprewitt commented Oct 10, 2023

This PR will port boto/s3transfer#274 to the CLI v2 to resolve the S3 configuration issue for multipart uploads.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (064f1a5) 93.13% compared to head (dca5239) 93.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #8235   +/-   ##
=======================================
  Coverage   93.13%   93.14%           
=======================================
  Files         364      364           
  Lines       38482    38482           
  Branches     6167     6167           
=======================================
+ Hits        35841    35844    +3     
+ Misses       1968     1965    -3     
  Partials      673      673           
Files Coverage Δ
awscli/botocore/handlers.py 93.95% <ø> (ø)
awscli/s3transfer/copies.py 100.00% <100.00%> (ø)
awscli/s3transfer/upload.py 94.77% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚢

@nateprewitt nateprewitt merged commit a1f5993 into aws:v2 Oct 11, 2023
24 checks passed
@nateprewitt nateprewitt deleted the ssec_fix branch October 11, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants